From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
David Bremner <david@tethera.net>,
Franz Fellner <alpine.art.de@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: known broken test for reindex tag preservation
Date: Mon, 04 May 2020 17:16:32 +0300 [thread overview]
Message-ID: <m2y2q73hvj.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20200504140024.1617656-1-david@tethera.net>
On Mon, May 04 2020, David Bremner wrote:
> In id:1588595993-ner-8.651@TPL520 Franz Fellner reported that tags
> starting with 'attachment' are removed by 'notmuch reindex'. This is
> probably related to the use of STRNCMP_LITERAL in
Haa, I looked this briefly but failed to see it is STRNCMP_LITERAL,
not STRCMP_LITERAL (the latter could be optimized strcmp using memcmp
w/ constant len)
Series LGTM (I'm trying to look away that 'we' passive ;)
Tomi
> _notmuch_message_remove_indexed_terms.
> ---
> test/T700-reindex.sh | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/test/T700-reindex.sh b/test/T700-reindex.sh
> index 9e795896..7b7e52de 100755
> --- a/test/T700-reindex.sh
> +++ b/test/T700-reindex.sh
> @@ -33,6 +33,15 @@ notmuch reindex '*'
> notmuch dump > OUTPUT
> test_expect_equal_file initial-dump OUTPUT
>
> +test_begin_subtest 'reindex preserves tags with special prefixes'
> +test_subtest_known_broken
> +notmuch tag +attachment2 +encrypted2 +signed2 '*'
> +notmuch dump > EXPECTED
> +notmuch reindex '*'
> +notmuch dump > OUTPUT
> +notmuch tag -attachment2 -encrypted2 -signed2 '*'
> +test_expect_equal_file EXPECTED OUTPUT
> +
> test_begin_subtest 'reindex moves a message between threads'
> notmuch search --output=threads id:87iqd9rn3l.fsf@vertex.dottedmag > EXPECTED
> # re-parent
> --
> 2.26.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2020-05-04 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 7:25 notmuch reindex wipes existing tags Franz Fellner
2020-05-04 10:30 ` David Bremner
2020-05-04 12:39 ` Franz Fellner
2020-05-04 13:39 ` David Bremner
2020-05-04 14:00 ` [PATCH 1/2] test: known broken test for reindex tag preservation David Bremner
2020-05-04 14:00 ` [PATCH 2/2] lib: replace STRNCMP_LITERAL in __message_remove_indexed_terms David Bremner
2020-05-04 15:16 ` Franz Fellner
2020-05-04 14:16 ` Tomi Ollila [this message]
2020-05-04 22:47 ` [PATCH 1/2] test: known broken test for reindex tag preservation David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y2q73hvj.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=alpine.art.de@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).