From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0MrEDtUoBGLRCAEAgWs5BA (envelope-from ) for ; Wed, 09 Feb 2022 21:49:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QHuXB9UoBGLVzwAAG6o9tA (envelope-from ) for ; Wed, 09 Feb 2022 21:49:25 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 67A6038944 for ; Wed, 9 Feb 2022 21:49:24 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 404135F714; Wed, 9 Feb 2022 20:49:23 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id E96FE5F711 for ; Wed, 9 Feb 2022 20:49:20 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 0E0AA1B0009A; Wed, 9 Feb 2022 22:49:20 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644439760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPBr7ep6jBT3DjW86B+NDozA9dV4Q8cT482znGZ1Ltk=; b=RWI/+kQO/cMdTXk7g9pHv5EtX0N3BdvfylYhaU4etSaRNEqDJYlDLlnu7GKyx7aLGudoya Me6cT1tP5miHcnQYF67kv6SzjMtcm2TyG6Ys1SryCC+nNIWXpa3IElTV7Nr39fYV4+eoJ7 D0SrdPQoNAwzR5BpJfIepzXoylps5ncTLTmbAcXPKVZSbqpGKYWUj+WVVtwWQ14sORsuUf rBB2ZXOcMpN/eYvzwSgQBg6kKZdneQKEOzx1gwtUPDQkLDa6xy2CZcBMd8Ll8M99vD37IL dr68KFYh3ce0NcZtUf40XgnX7gQyon+WuMduV+iYmy/w1RpEBELkyR8pfQ8ODg== From: Tomi Ollila To: Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons In-Reply-To: <8d483901f3cf9bee86d7359ff1d665943adcd31b.1644406756.git.git@grubix.eu> References: <8d483901f3cf9bee86d7359ff1d665943adcd31b.1644406756.git.git@grubix.eu> User-Agent: Notmuch/0.35+4~ge2bb4cd (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1644439760; a=rsa-sha256; cv=none; b=OWFxStUnobG89HDNbSLG7s7q1/ksmNrgBSGPp3wH+8rKP0sGTrLxvlJ4sY9Z/KhJYyLihC tW/MizTeitTzZW5cFfPr1Ixc6HZ4qWvZ9Ea8yzUMutZyyDsJiHua8Zo5cRudlzaFwHU32u fDJ57IF5Nq1Cq3Ratn9FfZKpqSRLJALVQbLpq64x1uchLEFPLs3Q0lKh08yCpzw5H2l3Ny q8t+TqJZRfn2mG6rrXUETb3B53HAs+kk6Hri0YIRK32mgEgDYANS9KjJPlgahXGKuWIaG/ FP/XA7fSbKHdtio0/TNPOIJvJRoHgRrkWQFqBzSX5cKt5WXrQwCnqXCl6tlOrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644439760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPBr7ep6jBT3DjW86B+NDozA9dV4Q8cT482znGZ1Ltk=; b=Z5DPT5GbYv/PGyXN299iuLOERbBQGddZvfxJlmszCtKr4IIguxnqQhgmMJ0r6+7pSvUoW1 8R7GcJPIEe83HdPtHqe1e3SyRHz5VD0jLRje6VVNjBVss+zX5MNu97jNDNY4RFQG+QA2x6 +amDNgg9ROLwh7JpjUKX2nT7b4hjDV7g4T8S706roHr2s33EM6yWfCZhzvCETcdmkJEa/N FGC3Ll+v6p6HoYNZ6qteKvYHGyY+cQ55ILVCDrpe3/wu/HZZx5acoMsoD2FAQYeD78axR2 Qd3H6HQvaX0o09ioOHQkMb0gsd249VVmooAOgPYlpgmO4iaEE+KNX04ThOstAw== Message-ID-Hash: FJGPSEOY7S566II5S7EYGTS2ALJF266Q X-Message-ID-Hash: FJGPSEOY7S566II5S7EYGTS2ALJF266Q X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644439764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=leb4zf8BzRfF3FeBwpaSZpRGDE0oa9n0vLkr2dlpwf8=; b=eTF4UuOZ2uNJ1s0Ve00gJ+d73dS1ekLzU47jUNpmUANihx6hEizAreSdU3ph+We0h0QLYl KxMWezfLawz3Lohw7H5zMnmzIC4vmQqQWu5AqdNhioQrwfSahCOah6DTFR++6biXJpqywe 4XS8LId4z996wYe6Bdrs+P3paTyoMOtVjNMLYu0G9AK1h1jsdwyyqCOljhGF0349WZfsba YfZOEN4IwqszkDk0lQ2epd948Okibl8runNInwraKPXPLyJQIwuUyhg7iv5oNg8Kcjmcdr OTXCF3prk7dm2abdDE2EtvUDa9+hlBRi6SQ7brqlFE9aYArAjBmrEtWxvG691Q== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1644439764; a=rsa-sha256; cv=fail; b=Vr4s7yZ4b51bRp5C1DL1oD7mq96761FVgz7GJ2upgGettEuNzFFcc4f5USAeRznrrJvFhs hjJHN8saIRb0UGDqZReC8nZdc5Ffyd7MUqX58xch6/NVAAjP43QDEJRx1W1Fqcwi3HVfNL cPCV1MhVsvt5xT8wCRWgTh/lTg0QAHl0H7FiwT8fm/m/ZE2+3CPXtoQXa7MUv3aKLKD6HO vsKK2C6bH1rfu1zdqcyytTNeVnXQozy/RHfhmxtrmgzg5DKdPXGQv+RCGFOQ0dcQ3RyngF WjbIycprXYOlD+9dWo9eLGNxSBiU/3l637cXqTfaIntAjb34SxgQDX1QA1hD4Q== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b="RWI/+kQO"; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b="RWI/+kQO"; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 67A6038944 X-Spam-Score: -0.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: uvrHGHBf3HVt On Wed, Feb 09 2022, Michael J. Gruber wrote: > If gdb is missing then some files are never written to so that the > comparisons of non-existing files succeeds for the wrong reason, > claiming that `notmch new` is idempotent when it was in fact never run. > > Catch this and (for lack of a better spot) set up the files with a > reason for the FAIL. > > Signed-off-by: Michael J Gruber > --- > test/T380-atomicity.sh | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh > index a6f1e037..7f618062 100755 > --- a/test/T380-atomicity.sh > +++ b/test/T380-atomicity.sh > @@ -90,6 +90,10 @@ if test_require_external_prereq gdb; then > i=$(expr $end - 1) > fi > done > +else > + echo -n "Test fails due to missing gdb." > searchall > + echo -n > expectall I am not much of a fan of 'echo -n' (I remember seeing -n (and newline echoed...), therefore first to use printf and second : > expectall (unless printf '' > expectall) > + outcount=0 > fi > > test_begin_subtest '"notmuch new" is idempotent under arbitrary aborts' > -- > 2.35.1.306.ga00bde9711