unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: mp39590@gmail.com, notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: add --without-api-docs option
Date: Thu, 11 Aug 2016 09:16:28 +0300	[thread overview]
Message-ID: <m2wpjnu8xv.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20160810130235.7108-1-mp39590@gmail.com>

On Wed, Aug 10 2016, mp39590@gmail.com wrote:

> From: Mikhail <mp39590@gmail.com>
>
> Add option to explicitly disable API man page build even if doxygen
> binary is available. --without-docs also implies not building API
> manpage.

This LGTM and worked fine on my manual ./configure command line testing

Tomi

>
> This change intended to add more distinctness into build system and
> allow user not to build unwanted man pages.
> ---
>  configure | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index ae0a027..fa4c5b5 100755
> --- a/configure
> +++ b/configure
> @@ -68,6 +68,7 @@ PYTHON=${PYTHON:-}
>  PREFIX=/usr/local
>  LIBDIR=
>  WITH_DOCS=1
> +WITH_API_DOCS=1
>  WITH_EMACS=1
>  WITH_BASH=1
>  WITH_RUBY=1
> @@ -137,7 +138,8 @@ Some features can be disabled (--with-feature=no is equivalent to
>  --without-feature) :
>  
>  	--without-bash-completion	Do not install bash completions files
> -	--without-docs			Do not install documentation and man pages
> +	--without-docs			Do not install documentation
> +	--without-api-docs		Do not install API man page
>  	--without-emacs			Do not install lisp file
>  	--without-ruby			Do not install ruby bindings
>  	--without-zsh-completion	Do not install zsh completions files
> @@ -184,11 +186,21 @@ for option; do
>      elif [ "${option%%=*}" = '--with-docs' ]; then
>  	if [ "${option#*=}" = 'no' ]; then
>  	    WITH_DOCS=0
> +	    WITH_API_DOCS=0
>  	else
>  	    WITH_DOCS=1
>  	fi
>      elif [ "${option}" = '--without-docs' ] ; then
>  	WITH_DOCS=0
> +	WITH_API_DOCS=0
> +    elif [ "${option%%=*}" = '--with-api-docs' ]; then
> +	if [ "${option#*=}" = 'no' ]; then
> +	    WITH_API_DOCS=0
> +	else
> +	    WITH_API_DOCS=1
> +	fi
> +    elif [ "${option}" = '--without-api-docs' ] ; then
> +	WITH_API_DOCS=0
>      elif [ "${option%%=*}" = '--with-emacs' ]; then
>  	if [ "${option#*=}" = 'no' ]; then
>  	    WITH_EMACS=0
> @@ -557,7 +569,7 @@ else
>  fi
>  
>  have_doxygen=0
> -if [ $WITH_DOCS = "1" ] ; then
> +if [ $WITH_API_DOCS = "1" ] ; then
>      printf "Checking if doxygen is available... "
>      if command -v doxygen > /dev/null; then
>  	printf "Yes.\n"
> -- 
> 2.9.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2016-08-11  6:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09 10:52 [PATCH] configure: add --without-api-docs option mp39590
2016-08-09 14:05 ` David Bremner
2016-08-09 14:59   ` Tomi Ollila
2016-08-10 13:02   ` mp39590
2016-08-11  6:16     ` Tomi Ollila [this message]
2016-08-11 13:02     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wpjnu8xv.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=mp39590@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).