unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Edmondson <dme@dme.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 1/1] emacs: Kill the stderr buffer when an async process completes
Date: Sun, 26 Aug 2018 22:16:32 +0100	[thread overview]
Message-ID: <m2woscq15b.fsf@dme.org> (raw)
In-Reply-To: <87a7p9pdpa.fsf@tethera.net>

On Sunday, 2018-08-26 at 08:30:41 -03, David Bremner wrote:

> David Edmondson <dme@dme.org> writes:
>>  
>> +(defun notmuch-start-notmuch-error-sentinel (proc event)
>> +  (let* ((err-file (process-get proc 'err-file))
>> +	 (err-buffer (or (process-get proc 'err-buffer)
>> +			 (find-file-noselect err-file))))
> Is the second case here (find-file-noselect) for the non-make-process
> code path, or something else? It might help to have a comment.

For non-make-process.  Updated patch sent.

>> +    (when err-buffer (kill-buffer err-buffer))))
>> +

dme.
-- 
I'm not the reason you're looking for redemption.

      reply	other threads:[~2018-08-26 21:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 10:32 Carbon (macOS) port asks about killing stderr buffer David Edmondson
2017-10-30 13:32 ` David Edmondson
2018-01-31 14:54 ` David Edmondson
2018-08-09 20:54 ` [PATCH v1 1/1] emacs: Kill the stderr buffer when an async process completes David Edmondson
2018-08-25 11:59   ` David Edmondson
2018-08-25 14:27   ` Sebastian Schwarz
2018-08-26 11:30   ` David Bremner
2018-08-26 21:16     ` David Edmondson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2woscq15b.fsf@dme.org \
    --to=dme@dme.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).