From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 9B4ED6DE0198 for ; Thu, 4 Oct 2018 14:17:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.469 X-Spam-Level: X-Spam-Status: No, score=0.469 tagged_above=-999 required=5 tests=[AWL=-0.183, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HW0mFhAFm5sr for ; Thu, 4 Oct 2018 14:17:15 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 054DE6DE0196 for ; Thu, 4 Oct 2018 14:17:13 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 7D7E1100033; Fri, 5 Oct 2018 00:16:58 +0300 (EEST) From: Tomi Ollila To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH v1 2/2] emacs: Update integration with third party packages. In-Reply-To: <20181004094545.18710-2-dme@dme.org> References: <20181004094545.18710-1-dme@dme.org> <20181004094545.18710-2-dme@dme.org> User-Agent: Notmuch/0.27+14~ge594ae3 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 21:17:16 -0000 On Thu, Oct 04 2018, David Edmondson wrote: > `mm-inline-text-html-with-images' was removed from mm-decode.el in > 2016 and replaced with `mm-html-inhibit-images'. > > `gnus-select-frame-set-input-focus' was removed from gnus-util.el in > 2016 and existed only for XEmacs compatibility. 2/2 looks good to me 1/2 is IMO okayish (but ymmv); i personally don't like __attribute__((unused)) as it is effectively the same as (void)var (neither notices the case when variable is actually used) also, 1/2 is farther away to fit onto 80 column terminal window ;/ Tomi > --- > emacs/notmuch-mua.el | 2 +- > emacs/notmuch-show.el | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el > index df2ac447..e205fa4c 100644 > --- a/emacs/notmuch-mua.el > +++ b/emacs/notmuch-mua.el > @@ -306,7 +306,7 @@ modified. This function is notmuch addaptation of > (if window > ;; Raise the frame already displaying the message buffer. > (progn > - (gnus-select-frame-set-input-focus (window-frame window)) > + (select-frame-set-input-focus (window-frame window)) > (select-window window)) > (funcall switch-function buffer) > (set-buffer buffer)) > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index a0a58373..78f1af47 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -604,7 +604,7 @@ will return nil if the CID is unknown or cannot be retrieved." > (unless (assq 'notmuch-show-mode w3m-cid-retrieve-function-alist) > (push (cons 'notmuch-show-mode #'notmuch-show--cid-w3m-retrieve) > w3m-cid-retrieve-function-alist))) > - (setq mm-inline-text-html-with-images t)) > + (setq mm-html-inhibit-images nil)) > > (defvar w3m-current-buffer) ;; From `w3m.el'. > (defun notmuch-show--cid-w3m-retrieve (url &rest args) > -- > 2.19.0 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch