From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/5] tests: run python-cffi tests
Date: Wed, 06 Nov 2019 22:51:42 +0200 [thread overview]
Message-ID: <m2wocc3ezl.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87h83hsq4o.fsf@tethera.net>
On Tue, Nov 05 2019, David Bremner wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>
>>
>> probably
>>
>> test_expect_success "${NOTMUCH_PYTHON} -m pytest \
>> --log-file=$TMP_DIRECTORY/test.output \
>> $NOTMUCH_SRCDIR/bindings/python-cffi/build/stage"
>>
>> worked (which reminds me out-of-tree... ;)
>>
>
> despite looking prettier this does not work because it looks for the
> "notdb" module in the current directory. It could work (maybe) if we set
> PYTHONPATH. Would that be better than the 'cd'?
So that would basically be:
test_expect_success "PYTHONPATH=$PWD${PYTHONPATH:+:$PYTHONPATH} \
${NOTMUCH_PYTHON} -m pytest \
--log-file=$TMP_DIRECTORY/test.output \
$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage"
(if it worked)
perhaps 'cd' in subshell is clearer
(i also wonder what --rootdir= does (and how new pytest is needed for that)
>> It prints the version, then exists. Could not figure out how to request
>> specific version in quick look (10 min search/trial/error session),
>> parsing version output is so... :/
>
> I think something like
>
> conf=$(mktemp)
> printf "[pytest]\nminversion=3.0\n" > $conf
> if pytest-3 -c $conf --version >/dev/null; then
> have_pytest=1
> else
> have_pytest=0
> fi
> rm -f $(conf)
>
> should work.
Right -- just that pytest-3 may not be available -- to iterate (tested)...
if ${NOTMUCH_PYTHON} -m pytest -c $conf --version >/dev/null 2>&1; then
(in this particular case redirecting both stdout and stderr is needed
to silence noise in all 'ordinary' cases, being
1) pytest module not available -- silence stderr
2) pytest version not new enough -- silence stderr
3) pytest exists and is new enought -- silence stdout )
next prev parent reply other threads:[~2019-11-06 20:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 1:39 python CFFI bindings integration into notmuch build/test David Bremner
2019-11-04 1:39 ` [PATCH 1/5] bindings/python-cffi: preserve environment for tests David Bremner
2019-11-04 1:39 ` [PATCH 2/5] configure: check for python cffi module David Bremner
2019-11-04 21:24 ` Tomi Ollila
2019-11-04 1:39 ` [PATCH 3/5] build: optionally build python-cffi bindings David Bremner
2019-11-04 21:26 ` Tomi Ollila
2019-11-05 0:32 ` David Bremner
2020-05-22 1:06 ` Daniel Kahn Gillmor
2019-11-04 1:39 ` [PATCH 4/5] tests: run python-cffi tests David Bremner
2019-11-04 16:18 ` Tomi Ollila
2019-11-04 16:57 ` David Bremner
2019-11-04 21:45 ` Tomi Ollila
2019-11-04 22:04 ` Tomi Ollila
2019-11-06 2:19 ` David Bremner
2019-11-06 20:51 ` Tomi Ollila [this message]
2019-11-09 1:36 ` David Bremner
2019-11-09 21:59 ` Tomi Ollila
2019-11-22 3:03 ` David Bremner
2019-11-26 0:52 ` David Bremner
2019-12-03 12:16 ` David Bremner
2019-11-04 1:39 ` [PATCH 5/5] travis: add python3-{cffi,pytest,setuptools} David Bremner
2019-11-04 11:10 ` python CFFI bindings integration into notmuch build/test David Bremner
2019-11-05 20:47 ` Tomi Ollila
2019-11-06 2:22 ` David Bremner
2019-11-14 18:52 ` Floris Bruynooghe
2019-11-14 20:20 ` Tomi Ollila
2019-11-14 22:24 ` Floris Bruynooghe
2019-11-14 23:09 ` Floris Bruynooghe
2019-11-16 15:51 ` David Bremner
2019-11-17 14:40 ` Floris Bruynooghe
2019-11-17 16:09 ` David Bremner
2019-11-16 15:43 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wocc3ezl.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).