From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wIC7DZzKyl6dVgAA0tVLHw (envelope-from ) for ; Sun, 24 May 2020 19:27:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id deScCZzKyl5tUAAAB5/wlQ (envelope-from ) for ; Sun, 24 May 2020 19:27:24 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 678F094030A for ; Sun, 24 May 2020 19:27:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 437106DE0F84; Sun, 24 May 2020 12:27:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rS0Bjc-PeAs5; Sun, 24 May 2020 12:27:18 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 227E86DE0B36; Sun, 24 May 2020 12:27:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id CA5366DE0B36 for ; Sun, 24 May 2020 12:27:15 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eVzePctKxd9q for ; Sun, 24 May 2020 12:27:15 -0700 (PDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by arlo.cworth.org (Postfix) with ESMTPS id 131C66DE0A89 for ; Sun, 24 May 2020 12:27:15 -0700 (PDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 90CE21B00193; Sun, 24 May 2020 22:27:13 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1590348433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e6pTnOdOjREbqyvkbbNyWrsEFWEo7Womm6Cv3fOixv8=; b=GHjZO4fzQhlwekBwaDoi4PegBz6y3CXLnU3aUvrxZjGzCo0ZnNpInAEPNcX0V8vRoQ6w/a Lg3SxTRpMRgL1saZBSCd8v6WCrBWLxhXPfbOkkexy1BbUbPzoJHjTSXTwiYGG2kBNWUy/9 Vy5uisp7LrMB3BDcnwE6+XuZVjz91eYUnvlCD4bv1YTXyo/WMqnzpQtOPmlaY8OdxAY42C TbkbaLJ8jRmmXeMeCj39mTGXd5xyvvqRJoZxcLJ3rw1FUupmaMhP3fvDFrKtNBTIQYTDrB ttank+tZZnnc52TrK+R27nGdVqMZMevY2GH9b6p5/e1i6qvMT93PiSBfA9yS5A== From: Tomi Ollila To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH v3 3/3] emacs: Use `dolist' instead of `mapcar' for side-effects In-Reply-To: <20200425201809.16503-3-jonas@bernoul.li> References: <20200415182822.10841-1-jonas@bernoul.li> <20200425201809.16503-1-jonas@bernoul.li> <20200425201809.16503-3-jonas@bernoul.li> User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1590348433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e6pTnOdOjREbqyvkbbNyWrsEFWEo7Womm6Cv3fOixv8=; b=ADL1oA/Bk5nP5aWVUZ6F8QzOeRmbSPXWHQ8Skp7UNRsesxsmzAHnThEPZaP+T/NhMEtOP5 onw4Z+0SYHdeZmaxeWVQeVLsApkBAjS/F0WwMFRGP2WS/QBGBhV00o1dRCf1b/UcqXB82k OldwpPn0O9CHpg1cn3zu4Nq24bHnwOGmfsBG35PWphWHOj6pKR04MKbx0wvNrkL1DX2Ho7 zA4ZVo3SksRJ5/R9J5f0LcAb56VZE6IFtAdjgTsygT+QAVZpuPTObztuaVtvAh4sXbZ3kj hUt6i4BPaELSIjYmohC1cmkbl3SZXP5jfAHLmKUUNvx3Sj9xTEjERq2y5IA+gw== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1590348433; a=rsa-sha256; cv=none; b=uEBz15T6VaeW9OsAHSOebovODJASmqr/tVcYF0JS7EO7feDG/VXVYnNLRUkM6MyKBfOlbb W5evhpB4q2+UtxmwrtIKa/j2BFAIDocFAGjMkFsXGfyubhGZmiYlNprY2XQe0d0X/Ul3O6 2gwo5hfWsAnNdojMeRw1Bbde3LkW33cxOyY9gGuoGhPdd8dHTiYrS8c8k1VmXqBFxKcstS HqZdWI5iyFNRO4NTo/4TA0kXQS/cQh7ZEDnUDxutYRRTRcC6cl8VF4x0FnV7ZiO890hIPB gOvZblZx8GPblJchu/zYJGon+kdA+dGJruPHvdLGXRFpql2SPjNEDzP6aSvdUw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=GHjZO4fz; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 1.99 X-TUID: bCWtXJPcaSF1 On Sat, Apr 25 2020, Jonas Bernoulli wrote: > As recommended by the byte-compiler. I don't know about v3 2/3, but this, v3 3/3 looks good to me. Tomi > --- > test/emacs-attachment-warnings.el | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/test/emacs-attachment-warnings.el b/test/emacs-attachment-warnings.el > index a23692d7..8f4918ef 100644 > --- a/test/emacs-attachment-warnings.el > +++ b/test/emacs-attachment-warnings.el > @@ -67,16 +67,15 @@ (defvar attachment-check-tests > > (defun notmuch-test-attachment-warning-1 () > (let (output expected) > - (mapcar (lambda (test) > - (let* ((expect (car test)) > - (body (cdr test)) > - (result (attachment-check-test body))) > - (push expect expected) > - (push (if (eq result expect) > - result > - ;; In the case of a failure, include the test > - ;; details to make it simpler to debug. > - (format "%S <-- %S" result body)) > - output))) > - attachment-check-tests) > + (dolist (test attachment-check-tests) > + (let* ((expect (car test)) > + (body (cdr test)) > + (result (attachment-check-test body))) > + (push expect expected) > + (push (if (eq result expect) > + result > + ;; In the case of a failure, include the test > + ;; details to make it simpler to debug. > + (format "%S <-- %S" result body)) > + output))) > (notmuch-test-expect-equal output expected))) > -- > 2.26.0