unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] python: convert shebangs to python3
Date: Sat, 13 Feb 2021 10:30:06 +0200	[thread overview]
Message-ID: <m2wnvcs73l.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20210213002622.377356-1-dkg@fifthhorseman.net>

On Fri, Feb 12 2021, Daniel Kahn Gillmor wrote:

> This is the last bit of "python" left in the notmuch codebase.
>
> https://www.python.org/dev/peps/pep-0394/#recommendation encourages
> "third-party distributors" to use more-specific shebang lines.  I'm
> not certain that the notmuch project itself is a "third-party
> contributor" but I think this is a safe way to encourage people to use
> python3 when they're developing notmuch.
>
> We already have python3 explicitly elsewhere in the codebase for
> developers (in nmbug).

LGTM

Tomi

>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
>  bindings/python/setup.py | 2 +-
>  test/json_check_nodes.py | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bindings/python/setup.py b/bindings/python/setup.py
> index d986f0c6..6308b9f9 100644
> --- a/bindings/python/setup.py
> +++ b/bindings/python/setup.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
>  
>  """
>  This file is part of notmuch.
> diff --git a/test/json_check_nodes.py b/test/json_check_nodes.py
> index 17403c57..fd8f1607 100755
> --- a/test/json_check_nodes.py
> +++ b/test/json_check_nodes.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
>  import re
>  import sys
>  import json
> -- 
> 2.30.0
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

  reply	other threads:[~2021-02-13  8:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-13  0:26 [PATCH] python: convert shebangs to python3 Daniel Kahn Gillmor
2021-02-13  8:30 ` Tomi Ollila [this message]
2021-02-15 20:40   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wnvcs73l.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=dkg@fifthhorseman.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).