From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0MW0Nzm4jWDuCAEAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 22:21:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MKlmMzm4jWBDEQAAB5/wlQ (envelope-from ) for ; Sat, 01 May 2021 20:21:13 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D89518F1A for ; Sat, 1 May 2021 22:21:13 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id EB71F2717A; Sat, 1 May 2021 16:21:10 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 439FB271E9 for ; Sat, 1 May 2021 16:21:07 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 22B9A1B0102D; Sat, 1 May 2021 23:21:06 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9dCAraYv9C141q1hJfg5yVWiAJRvZNIhjE5aCSUM+Z4=; b=cN7x3urW96MG9Mmn3sYVnn8r2ibFkcie5tmu+PtAWexixsfivZhcV5TEJ4LP43EH6uW8Xn 9oPnicAhJ7/DH0wDwT5DQKtDWidI4GRFFRE1Ie9C1QVFkHtkgTbJRMebaYtxqACcRcRCDr xjqpoNp/yatIeKGP6yEWuC6tHDAcH6AgWTwPcsx7e2MPtk2bxHnAas1Q47cApCTJtJwKsy 5criUazazwmk3oBnGV6kzcouPHZfxWW3VeBk2lOZ2fsT2mua/h4/rseOvzuFeQtm91N37C q/N0fAEdNxUNQ+oAS05xeaMYlvfxXtIAL0D1ffdEcct/wse20yLvnXTrYdpKCw== From: Tomi Ollila To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 11/13] test: emacs: fix a couple of shellcheck complaints In-Reply-To: <20210501115422.483314-12-felipe.contreras@gmail.com> References: <20210501115422.483314-1-felipe.contreras@gmail.com> <20210501115422.483314-12-felipe.contreras@gmail.com> User-Agent: Notmuch/0.31.4+128~gc67b63a (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9dCAraYv9C141q1hJfg5yVWiAJRvZNIhjE5aCSUM+Z4=; b=ieD0jImIkxiG4n29eFXZQk9uk8qPl/3wKJ0eCVweizGjU5uqkA7KCvl0dz3eNF7bfZdseb IKRHwqRpJiawx/qCW26j0nv2WzLMksi89O/O9k1+W9SJJ9HTgE+J7iFUfB/OKhT5ydC3T1 jtUE6TuzLOzGsTn6Rv8ga4sbabK/mmIgrnHpOwBB++pYSf4rfUUnsWQPBevuq6/PgN5701 EkdlB+DSgsKopENpTDxb9n3+MzzhdOb3ROX+3xraYEPrrPXubPx7OCX4TU4wh4sDGsvQym IJNgNFoU79zi34GwtoKbO196AqEOMTBxxGLuHv7vFvWRlb+oDIOkmYBOgbLf3g== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1619900466; a=rsa-sha256; cv=none; b=uQQgetxz7/0VsgRwOKdPtKl2KXPXWYVOUEx2kjLq6bMYluUFf9aKx6S6rQ/cpOe02aWZv1 NAWsFODjBJqG5Wii8U9SCTX2A4gr03MPbjcpC9MZnuM+SUjM97bZg0IBB/opKs1lGMldot wT8AwAxshJMFJizQNHMFgOnyYBu54S1s1hTkLFUBZ36SS2aNc9efHesjUvqxCJE87Tq0qL apuousHhSQUp5LacsOwuJ0dnQSLPD3jJfDoIUaEtmIrjAoUphAYZO6A+OqOeD01a8DDeVQ VFc3tIwBCkK/VCU3A0cBVVmXiMD2NL5/Ui+4FwywlCWWk479htrKdR0i/27tZA== Message-ID-Hash: QCOWPLNAZZ24FXCMG2VA7AQVR3LHHGRJ X-Message-ID-Hash: QCOWPLNAZZ24FXCMG2VA7AQVR3LHHGRJ X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619900473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=UAdnWki+cSbnhxctqm4+wRsSFACK8Im1ispqc1O+yeM=; b=KhA5e2xBQbhLcPgz+pXHk2WXE9USebUSRYYfUfduSXd3XOayOIDLmCiPh9Br19TluCe+LH 8898lrSRxv/dzT9/hnCCLNcamy1nDDuM585cWPaeXfzD3QhcTQGQsGtpNiqElOHcczGZLY gxl+xZXsVpyvb2TappwuH1fnjSzMkmIslqQZCH9AgjcLK0EQ4GUWmOQTqew01V3v5TpUoU D+R5o4zUA50ag9EQkFmlYBvxi1zDVsZE9L7d0fYFE/JZTPSwYggri3R3HOXkFf8wq4SFR/ DRq6WJ4MllO9jqFdWY4/uADLW+MHu75sm7uilQJHhMRKiGwNAGIpZU5eH9vHdw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1619900473; a=rsa-sha256; cv=fail; b=LwwH+K/Avcbfh/LPpf2RHdtQZT/CUa83UdXnIaWPJN56ZmYG2pb/5LOWASwUJF00nohLyU ZhH5YQveQjm9mlWz3Lx6OEDSGFsTEN0ZZoYfOV9Bi+wYbbgVfG8+cgdgQMJkWKadvYUp4w tEWEbH28UXhTdK17tXXiziJM4eKFC8zNMnvcA/9t/NOl22wec5AWBqmTSPD0qnypdxY/+b CGX0gbmWQABYEr8mzH8O/0BDwVsN1/noUpgLD4oUSC0m1hWpoQl7gYmGBixHO+Te7Kd9AZ Ak7Hv5wgi/f5KS1EmR6HzqYG917tuEIdWOZXbVkbxM63YSpS68x9PYxuQykFCg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=cN7x3urW; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=cN7x3urW; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 3D89518F1A X-Spam-Score: 0.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: mv+ncbVJ28l5 On Sat, May 01 2021, Felipe Contreras wrote: LGTM > In test-lib-emacs.sh line 20: > test_require_external_prereq ${TEST_EMACS} || ret=1 > ^-----------^ SC2086: Double quote to prevent globbing and word splitting. > > Did you mean: > test_require_external_prereq "${TEST_EMACS}" || ret=1 > > In test-lib-emacs.sh line 21: > test_require_external_prereq ${TEST_EMACSCLIENT} || ret=1 > ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. > > Did you mean: > test_require_external_prereq "${TEST_EMACSCLIENT}" || ret=1 > > Signed-off-by: Felipe Contreras > --- > test/test-lib-emacs.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test/test-lib-emacs.sh b/test/test-lib-emacs.sh > index 3075fa59..bf875a28 100644 > --- a/test/test-lib-emacs.sh > +++ b/test/test-lib-emacs.sh > @@ -16,8 +16,8 @@ > > test_require_emacs () { > local ret=0 > - test_require_external_prereq ${TEST_EMACS} || ret=1 > - test_require_external_prereq ${TEST_EMACSCLIENT} || ret=1 > + test_require_external_prereq "$TEST_EMACS" || ret=1 > + test_require_external_prereq "$TEST_EMACSCLIENT" || ret=1 > test_require_external_prereq dtach || ret=1 > return $ret > } > -- > 2.31.0 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org