[BUG?] Pressing SPACEbar is not doing what's expected.

[BUG?] Pressing SPACEbar is not doing what's expected.

[Xavier Maillard]

Hi,

I recently upgraded my notmuch installation here (passing from 0.6 or
such to latest 0.10.x series).

Problem is now, pressing SPACE in a notmuch-show buffer no longer scroll
in the message as it used to do.

SPC is bound to run command notmuch-show-advance-and-archive and its
docstring says:

This command is intended to be one of the simplest ways to
process a thread of email. It does the following:

        If the current message in the thread is not yet fully visible,
        scroll by a near screenful to read more of the message.

        Otherwise, (the end of the current message is already within the
        current window), advance to the next open message.

        Finally, if there is no further message to advance to, and this
        last message is already read, then archive the entire current
        thread, (remove the "inbox" tag from each message). Also kill
        this buffer, and display the next thread from the search from
        which this thread was originally shown.

What happens here is just what is described in paragraph 2. Although I
am in situation described in first paragraph, pressing SPC just advance
to next message and never scroll to see the next part of the current
message.

How can I change this behaviour ? Does I need to do something in my
.emacs file ?

Thank you very much.

/Xavier

Re: [BUG?] Pressing SPACEbar is not doing what's expected.

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On Thu, 22 Dec 2011 00:08:38 +0100, Xavier Maillard <xma@gnu.org> wrote:
> What happens here is just what is described in paragraph 2. Although I
> am in situation described in first paragraph, pressing SPC just advance
> to next message and never scroll to see the next part of the current
> message.

Hi, Xavier.  I have noticed this as well, and it's definitely a bug and
not a feature (there's no way to change this behavior).  I think it has
to do with there being hidden text at the end of the current message,
and notmuch somehow assuming that it is at the end of the message when
it's really not.

This issue has actually been addressed once, with a patch in fact [0].
However, somehow my patch to split the "and-archive" bit out of the
notmuch-show-advance-and-archive function [1] seems to have exposed a
problem.

I've been meaning to give it a look, but I'm hoping Dmitry can look at
it, since he understands this stuff better than I do.

jamie.

[0] id:"1320570241-30733-2-git-send-email-dmitry.kurochkin@gmail.com"
[1] id:"1321219008-11690-2-git-send-email-jrollins@finestructure.net"

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [BUG?] Pressing SPACEbar is not doing what's expected.

[Xavier Maillard]

Hi Jamie,

On Wed, 21 Dec 2011 15:19:24 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Thu, 22 Dec 2011 00:08:38 +0100, Xavier Maillard <xma@gnu.org> wrote:
> > What happens here is just what is described in paragraph 2. Although I
> > am in situation described in first paragraph, pressing SPC just advance
> > to next message and never scroll to see the next part of the current
> > message.
> 
> Hi, Xavier.  I have noticed this as well, and it's definitely a bug and
> not a feature (there's no way to change this behavior).  I think it has
> to do with there being hidden text at the end of the current message,
> and notmuch somehow assuming that it is at the end of the message when
> it's really not.

Well, the good news is that I am not alone :D At the beginning, I
thought it was me.

> This issue has actually been addressed once, with a patch in fact [0].
> However, somehow my patch to split the "and-archive" bit out of the
> notmuch-show-advance-and-archive function [1] seems to have exposed a
> problem.

I hope you (notmuch hackers) will find a solution to this bug.

Take care guys and thank you for such an awesome tool !

/Xavier

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

[Aaron Ecay]

Text properties change between characters; prev-s-c-property-change
returns the position after the change.  Thus, it is still inside the
invisible region.
---
 emacs/notmuch-show.el |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f52f233..905c9ec 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1169,8 +1169,9 @@ current window), advance to the next open message."
 	 (ret nil))
     (while (invisible-p visible-end-of-this-message)
       (setq visible-end-of-this-message
-	    (previous-single-char-property-change visible-end-of-this-message
-						  'invisible)))
+	    (max (point-min)
+		 (1- (previous-single-char-property-change
+		      visible-end-of-this-message 'invisible)))))
     (cond
      ;; Ideally we would test `end-of-this-message' against the result
      ;; of `window-end', but that doesn't account for the fact that
-- 
1.7.8

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

[Xavier Maillard]

Hey Aaron,

On Thu, 22 Dec 2011 09:24:20 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> Text properties change between characters; prev-s-c-property-change
> returns the position after the change.  Thus, it is still inside the
> invisible region.

This patch works for me (at least on all the messages I tested it
on). Thank you very much !

/Xavier

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

On Thu, 22 Dec 2011 09:24:20 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> Text properties change between characters; prev-s-c-property-change
> returns the position after the change.  Thus, it is still inside the
> invisible region.

Thanks Aaron!  I just tested this and it does seem to fix the issue.

Definitely +1 for this.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

[David Bremner]

On Thu, 22 Dec 2011 09:24:20 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> Text properties change between characters; prev-s-c-property-change
> returns the position after the change.  Thus, it is still inside the
> invisible region.

Pushed, 

d

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

[Dmitry Kurochkin]

Hi Aaron.

Thanks for the fix.

Would be nice to have a test for it :)

Regards,
  Dmitry

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

[Dmitry Kurochkin]

Hi Aaron.

Thanks for the fix.

Would be nice to have a test for it :)

Regards,
  Dmitry