From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: show: stop stderr appearing in buffer
Date: Thu, 12 Sep 2013 14:49:23 +0300 [thread overview]
Message-ID: <m2vc26p8e4.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87ppsepeo9.fsf@qmul.ac.uk>
On Thu, Sep 12 2013, Mark Walters <markwalters1009@gmail.com> wrote:
> Hi
>
> On Tue, 10 Sep 2013, David Bremner <david@tethera.net> wrote:
>>> Ideally, we would put this output in the notmuch errors buffer but the
>>> handler is called asynchronously so we don't know when the output will
>>> appear. Thus if we put it straight into the errors buffer it could get
>>> interleaved with other errors, otoh we can't easily tell when we
>>> have got all the error output so can't wait until the process is complete.
>>
>> Hi Mark;
>>
>> I think your patch is OK, but would it be much harder to created a named
>> buffer like *notmuch-view-$message-d* ? (using e.g. the code from
>> notmuch-show). I might make debugging easier.
>
> Yes this is easy. There are several possibilities and I am not sure
> which is best (some are clearly bad but are worth mentioning anyway).
>
> 1) have a single buffer for part errors; this would accumulate stuff and
> output seems to get interleaved so this is probably useless.
>
> 2) have a buffer for each part viewer as you describe.
>
> 3) have a buffer for each part viewer but start its name with a space so
> it doesn't show up in buffer lists but is findable (maybe)
>
> 4) stick with just the temp buffer approach
Maybe check whether the temp buffer is empty. if not, use
(buffer-string) & (notmuch-logged-error) to append the message
to the *Notmuch errors* buffer... just that notmuch-logged-error
signals an error which we may not want to do...
We could unify to "*Notmuch Messages*" and have more functions to
append data there... somewhat analogous to current *Messages* buffer
just that that one has so much noise...
Tomi
>
> Also, we could have it togglable with some sort of debug flag. In some
> senses 3 is nice but you would probably end up with 10's or even
> hundreds of hidden buffers which seems bad. In 2 you see them so you
> probably kill them as you go but I think they would be pretty
> annoying. A key difference from the accumulated show/search/pick buffers
> is that, at some point, you did want to see those buffers.
>
> Since all these approaches are easy to implement it is really up to us
> which we want.
>
> Any thoughts?
>
> Mark
>
>
>>
>> Of course those buffers would accumulate, along with show, search and
>> pick buffers...
>>
>> Or we could push this as is, and add some debugging facility later like
>> a variable notmuch-view-errors-buffer.
>>
>> d
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-09-12 11:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 21:16 [PATCH] emacs: show: stop stderr appearing in buffer Mark Walters
2013-09-10 14:12 ` David Bremner
2013-09-12 9:33 ` Mark Walters
2013-09-12 10:56 ` David Bremner
2013-09-12 11:49 ` Tomi Ollila [this message]
2013-09-12 12:09 ` Mark Walters
2013-09-12 12:20 ` Tomi Ollila
2013-09-12 15:45 ` Mark Walters
2013-09-13 6:13 ` Tomi Ollila
2013-09-12 14:53 ` Austin Clements
2013-09-12 15:43 ` Mark Walters
-- strict thread matches above, loose matches on Subject: below --
2013-11-13 9:03 Mark Walters
2013-11-13 21:58 ` Tomi Ollila
2013-11-18 11:35 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vc26p8e4.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).