From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: push mark before signature on reply
Date: Sat, 29 Mar 2014 09:08:03 +0200 [thread overview]
Message-ID: <m2vbux1nzg.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1396029865-23133-1-git-send-email-jani@nikula.org>
On Fri, Mar 28 2014, Jani Nikula <jani@nikula.org> wrote:
> We push mark on reply so user can cut the quote. Push the mark before
> signature, if any, instead of end of buffer so the signature is
> preserved.
>
> This is consistent with message-kill-to-signature.
> ---
LGTM. +1
> emacs/notmuch-mua.el | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index b16a10ecd379..ba3ef275ec5e 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -226,8 +226,12 @@ list."
> ;; Quote the original message according to the user's configured style.
> (message-cite-original))))
>
> - (goto-char (point-max))
> + ;; Push mark right before signature, if any.
> + (message-goto-signature)
> + (unless (eobp)
> + (end-of-line -1))
> (push-mark)
> +
> (message-goto-body)
> (set-buffer-modified-p nil))
>
> --
> 1.9.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-03-29 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 18:04 [PATCH] emacs: push mark before signature on reply Jani Nikula
2014-03-29 7:08 ` Tomi Ollila [this message]
2014-03-30 7:03 ` Mark Walters
2014-03-30 22:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vbux1nzg.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).