From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib: convert two "iterator copy strings" into references.
Date: Fri, 02 Jan 2015 22:07:38 +0200 [thread overview]
Message-ID: <m2vbkp0wvp.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1420215652-4131-1-git-send-email-david@tethera.net>
On Fri, Jan 02 2015, David Bremner <david@tethera.net> wrote:
> Apparently this is a supported and even idiomatic way of keeping a
> temporary object (e.g. like that returned from an operator
> dereference) alive.
> ---
Based on internet search with words 'c++ reference to temporary' (*)
I believe the change is working one.
Tomi
(*) Uh, reading those explations gives me a headache >;)
>
> I decided it was better to do both of these "keepalive" strings the
> same way, so I applied the parent patch as is.
>
> lib/message.cc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/message.cc b/lib/message.cc
> index bacb4d4..956a70a 100644
> --- a/lib/message.cc
> +++ b/lib/message.cc
> @@ -283,7 +283,7 @@ _notmuch_message_get_term (notmuch_message_t *message,
> if (i == end)
> return NULL;
>
> - std::string term = *i;
> + const std::string &term = *i;
> if (strncmp (term.c_str(), prefix, prefix_len))
> return NULL;
>
> @@ -641,7 +641,7 @@ _notmuch_message_add_directory_terms (void *ctx, notmuch_message_t *message)
> unsigned int directory_id;
> const char *direntry, *directory;
> char *colon;
> - const std::string term = *i;
> + const std::string &term = *i;
>
> /* Terminate loop at first term without desired prefix. */
> if (strncmp (term.c_str (), direntry_prefix, direntry_prefix_len))
> --
> 2.1.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2015-01-02 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 11:37 BUG: Using pointer that points to a destructed string's content Tamas Szakaly
2014-12-26 22:03 ` David Bremner
2014-12-26 23:06 ` Tamas Szakaly
2014-12-28 10:45 ` [PATCH] lib: another iterator-temporary/stale-pointer bug David Bremner
2015-01-01 14:49 ` Jani Nikula
2015-01-02 16:20 ` [PATCH] lib: convert two "iterator copy strings" into references David Bremner
2015-01-02 17:52 ` Jani Nikula
2015-01-02 20:07 ` Tomi Ollila [this message]
2015-01-03 9:03 ` David Bremner
2014-12-27 8:33 ` [PATCH] lib: collapse computation of directory_id into a single expression David Bremner
2015-01-03 13:30 ` BUG: Using pointer that points to a destructed string's content David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vbkp0wvp.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).