From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Cc: David Bremner <david@tethera.net>
Subject: Re: [PATCH] devel: two scripts for checking proposed changes
Date: Mon, 28 Jun 2021 17:19:20 +0300 [thread overview]
Message-ID: <m2v95yf4wn.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20210628140810.1842069-1-david@tethera.net>
On Mon, Jun 28 2021, David Bremner wrote:
> It took me a bit of effort to get the correct oneliner to reindent
> elisp from the command line, so I saved the results as
> 'reindent-elisp'.
>
> 'check-notmuch-commit' is an updated version of a script I have been
> using (although not always as consistently as I should) before sending
> patches to the list.
>
> Although it requires a bit more tooling, encouraging people to use
> check-notmuch-commit might reduce the number of round trips to the
> list for style nitpicks.
> ---
> devel/check-notmuch-commit | 20 ++++++++++++++++++++
> devel/reindent-elisp | 8 ++++++++
> 2 files changed, 28 insertions(+)
> create mode 100755 devel/check-notmuch-commit
> create mode 100755 devel/reindent-elisp
>
> diff --git a/devel/check-notmuch-commit b/devel/check-notmuch-commit
> new file mode 100755
> index 00000000..98a19a64
> --- /dev/null
> +++ b/devel/check-notmuch-commit
> @@ -0,0 +1,20 @@
> +#!/bin/sh
> +
> +# Usage suggestion:
> +# git rebase -i --exec devel/check-notmuch-commit origin/master
> +
> +set -e
> +make test
This may fail miserably (or is painfully slow (doing configure and make...)
> +for file in $(git diff --name-only HEAD^); do
is this also mentioning deleted files... ? (--diff-filter=AM) ?
> + case $file in
> + *.c|*.h|*.cc|*.hh)
> + uncrustify --replace -c $(dirname "$0")/uncrustify.cfg "$file"
dirname "$0" could be resolved once before loop.
> + ;;
> + *.el)
> + $(dirname "$0")/reindent-elisp "$file"
> + ;;
> + esac
> +done
> +
> +git diff --quiet
> +
> diff --git a/devel/reindent-elisp b/devel/reindent-elisp
> new file mode 100755
> index 00000000..f6ce3844
> --- /dev/null
> +++ b/devel/reindent-elisp
> @@ -0,0 +1,8 @@
> +#!/bin/sh
> +
> +if [ $# -lt 1 ]; then
if [ $# -ne 1 ] ... (see at the end)
> + printf "usage: $0 <path.el>\n"
Angle brackets are bad in example -- if copy-pasted to terminal (and badly
edited) does redirections...
> + exit 1
> +fi
> +
> +emacs -Q --batch $1 --eval '(indent-region (point-min) (point-max) nil)'
> -f save-buffer
... as here is $1 -- which should be quoted as "$1"
> --
> 2.30.2
next prev parent reply other threads:[~2021-06-28 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 14:08 [PATCH] devel: two scripts for checking proposed changes David Bremner
2021-06-28 14:19 ` Tomi Ollila [this message]
2021-06-29 11:27 ` David Bremner
2021-07-23 20:13 ` Tomi Ollila
2021-10-10 11:54 ` [PATCH v2] devel: script for checking a commit (series) David Bremner
2021-10-10 19:02 ` Tomi Ollila
2021-10-10 23:57 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2v95yf4wn.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).