From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uJ3PEfMoBGK4JgEAgWs5BA (envelope-from ) for ; Wed, 09 Feb 2022 21:49:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YPW5DvMoBGL2QAAAauVa8A (envelope-from ) for ; Wed, 09 Feb 2022 21:49:55 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DEDC332222 for ; Wed, 9 Feb 2022 21:49:54 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id BA77E5F717; Wed, 9 Feb 2022 20:49:53 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 3DFC05F711 for ; Wed, 9 Feb 2022 20:49:51 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id B67EE1B0009A; Wed, 9 Feb 2022 22:49:50 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644439790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Usp6JtQ++5NPm5hlrodl9+zGIzuATRTpX+6rD0BSHdo=; b=RzRWloUrjgg5QS17msI24HIDuzfTOmMt9hcH/zo3x2dlUitWFdFquzQMhlSXCU9szaHIRP gJkF/Upc3dU4UI2WJsdEPYlbHNS4BNznTN6gzwGG/pUbLKjJFPi1eHIoLEccKawchBLpqU CFCrQk6M5cvqedzOlUXRnTOJQPxu2vV7C1OrAZ8qh8LVrTdjx0bVI9WmWyATuqJq5MRD1u ntMfx/j8uOTZJpNnzGY0os37TO4glwrx099BsQmMpM+zTSEVtSNxe11VbXS4X2LOLTesiV 0qvOCTXmvSV7kpiYbI+SsVR3bkVGJOT9F7Y18cqCauOhzg24UFc+vpsDou+X6Q== From: Tomi Ollila To: Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH 3/4] test: reword T380.2 to be clearer In-Reply-To: <243937764b79b6dce2d66299dd2b11caed258de2.1644406756.git.git@grubix.eu> References: <243937764b79b6dce2d66299dd2b11caed258de2.1644406756.git.git@grubix.eu> User-Agent: Notmuch/0.35+4~ge2bb4cd (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1644439790; a=rsa-sha256; cv=none; b=PN2So5WXo71SALpjL5xQWwg01I5LgNpZvXA+RXirr8YIWlHlARc885hwbRyO9Azw7aShOM z2aRNcIs3HL2APXA98DNf/ASK7O2gsaN/uxMkqydWQccRRsdPFtG7p64Dl0HEXYzNTenn1 7Cwn7jkNhCDqt1SBQwTeuoxxYszvoB58C51VYrLUL98Af3tY5Onl7XlI2lRf4cNXxvzMmM IYq3uifssjH7si7K9bHGYOsPc4jv1y4xdOv1JI7YtBhbPWzwc+g1w9V+3Twd5zRk73cJ8T KtKuTFfrCGrOO0N8897ZjMSJOFugYqO2gT6La1zLA3N9anenCMtOXRL9wY5LSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644439790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Usp6JtQ++5NPm5hlrodl9+zGIzuATRTpX+6rD0BSHdo=; b=HwSJCtjeVPoJ+L7MOt/bWaVmEtvG6189tJRv4X9AY5T25OTHDb9F2sq5cAMgLBfARxc1c2 09oqFQpN/ldUWck4J4gBcw/1AYlmxfdyqL3XeNkCaz+1rt9+1H6pOJ6K/saVVHYOTdglzP 4R7jYb9wDMpUJkWrY9yTKUZWzebv9DH6/QuZo6BptAE6APhRm5g6PP0tzDq6XUMNbReKRr GWoDH+TdFPmJ9kMcd86nieNbGZ52WaMQyNzGWBLdyG+Y5FaS1PY2YqjezPB2HvaR+tfDRF ma8RZtuEqgyREjR/53tOYcj2NUtWeFFkbFbtZC1GOXgk7bhbWBqySdUDsZ3RIQ== Message-ID-Hash: I2TM7GFHZMFAFC3VPIKAQHXN73D56XZ4 X-Message-ID-Hash: I2TM7GFHZMFAFC3VPIKAQHXN73D56XZ4 X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644439794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+EXHErzfYBKCYyzGFCrYgzNYm42dBTdh8Bt5bVyYoMc=; b=Sx9SqejKrfc9yPsqyS+LyXCB5sSPrjal15mOJ9EYHg2gwam9WdpUaj0pP6UpFrpGN5bDPQ RkkH6s1Jaet0/UNhe2e+qWxbXmVmi0SaaMw1Mh8McNmGVV6II0pKmBMS1xHlm57n9OAsTr fibuQNUsNzLtVN+yz86mlcYzC0iqMg3sdbKbTFfP69XE+FjRg2qDwpun5VCz5iRw1Gw2mx 1D6NJWU6+vdRsNL1UQU4ZOMPeRqFN2i3dPOp9Cc+lCfDvpTNaxOwGfKgjVXfsiuTfPZsYZ ob2B/9nSoPerGDk6Buiogc+QcTVDTnerEeB2zGkz/N2NDassPueeCi/427HH6A== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1644439794; a=rsa-sha256; cv=fail; b=RTXYtfJrou23/AJb3sf19VU4/aLzrCOJVqOVKT953/PYgp0Dg961NljiCSzXXdmr7AqlKz BNs6Ovimors2UtkFL51LpxCDw81iE9fVDdV2dYorgqOVW7LD3z9ujMqt7ALgBb034tAcBN aeMh3OgM9hAEGs65nwh8EiYuoC03McexFpwKedRoOK9E+VtBae4m7nSdPjuO93G0FE8q11 c3JCKacB3VKIMJLh6sOpHVI5fKoc7PtckVPZKxQpGk1lWmUeacBqhXyImEEj7ZSwSzrUEq 1xJMqbTgAwJWdfwKvkgTsSEwsfTWc3JKZJKM8+4u3FihQ28kJjsA4xOjB7X13Q== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=RzRWloUr; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.82 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=RzRWloUr; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: DEDC332222 X-Spam-Score: -1.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2nhfpo6vm3MF On Wed, Feb 09 2022, Michael J. Gruber wrote: > T380.2 gives a test description which depends on the actual test output, > rather than the expected outcome or actual test which is performed. > > So, when the test fails due missing abort points, the test describes > itself as `detected 0>10 abort points` so that it's not clear which part > or which number is the expectation. (Also, `0>10` is no number ...) > > When the test is not run for some reason and fails because of that, the > test describes itself as `detected >10 abort points`, which arguably is > better or worse. > > Reword it to say `detected more than 10 abort points`, which is the > actual expectation and what we test for. The failing test line still > gives the actual number. > > Signed-off-by: Michael J Gruber > --- > test/T380-atomicity.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh > index 7f618062..49df5c38 100755 > --- a/test/T380-atomicity.sh > +++ b/test/T380-atomicity.sh > @@ -99,7 +99,7 @@ fi > test_begin_subtest '"notmuch new" is idempotent under arbitrary aborts' > test_expect_equal_file expectall searchall > > -test_begin_subtest "detected $outcount>10 abort points" > +test_begin_subtest "detected more than 10 abort points" probably ok (I trust the commit msg is right :D) > test_expect_success "test $outcount -gt 10" > > test_done > -- > 2.35.1.306.ga00bde9711 > > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org