From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EA865429E54 for ; Sun, 22 Jan 2012 14:09:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.463 X-Spam-Level: X-Spam-Status: No, score=0.463 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, RDNS_DYNAMIC=0.363] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FJJXjdlR7eS5 for ; Sun, 22 Jan 2012 14:09:35 -0800 (PST) Received: from xhlj.maillard.im (cha51-3-88-164-105-66.fbx.proxad.net [88.164.105.66]) by olra.theworths.org (Postfix) with ESMTP id BB8EA429E40 for ; Sun, 22 Jan 2012 14:09:34 -0800 (PST) Received: from xhlj.maillard.im (xhlj.maillard.im [127.0.0.1]) by xhlj.maillard.im (Postfix) with ESMTP id DA1CC2C9E2; Sun, 22 Jan 2012 23:09:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=maillard.im; h=from:to:cc :subject:in-reply-to:references:reply-to:date:message-id :mime-version:content-type; s=postfix; bh=OWwglZ5/TwuRspNIKlysO8 yYoWo=; b=jeY+VXbYfJep0rE3yDti12j684h2R82HL2Ifg8GcAo1HZxFWdNrBUL B5ExnaoTmLNsk7NGK92zlevSASzKgRQPHcW7IuQ3JidRi3KzgR2PJalpIMcpgIKD mRu272YTpSnfpZ0txZoJ8XB97hellSjFP2WqgpKJquzbNA0qEUt94= DomainKey-Signature: a=rsa-sha1; c=nofws; d=maillard.im; h=from:to:cc :subject:in-reply-to:references:reply-to:date:message-id :mime-version:content-type; q=dns; s=postfix; b=eCixXG5wEeNPL1Bq PFoGffChOWxcZBAXmrOBAUOQTc7xhquj38T/QbJYUi6agk8GRdivGRh5HAIE5BPg aUxhTGJCVFkZARMoKLbaBllNjHB9ifhg1G6qg5gKto75FGdWsPQFfMj4Y4cBi9BC a0PfGSa7q6zts76ioMMq+8nPKcw= Received: from maillard.im (cha51-3-88-164-105-66.fbx.proxad.net [88.164.105.66]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by xhlj.maillard.im (Postfix) with ESMTPSA; Sun, 22 Jan 2012 23:09:30 +0100 (CET) From: Xavier Maillard To: Pieter Praet , Austin Clements Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions In-Reply-To: <1327000744-25463-1-git-send-email-pieter@praet.org> References: <1326586654-16840-3-git-send-email-amdragon@mit.edu> <1327000744-25463-1-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.11 (http://notmuchmail.org) Emacs/23.2.1 (i486-slackware-linux-gnu) Date: Sun, 22 Jan 2012 23:09:30 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Xavier Maillard List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2012 22:09:36 -0000 Hey Pieter, On Thu, 19 Jan 2012 20:19:00 +0100, Pieter Praet wrote: > Nice feature! I won't be using it myself, but I can imagine it being > *very* useful for those who still feel the need to "delete" email :). Adding a 'deleted' tag does not mean there will be a delete/purge process ;) (currently I got 5k messages with the tag deleted ;). > Nitpicking: > [ ... ] > So I'd like to suggest replacing all occurences of "auto_exclude_tags" > with "search_exclude_tags" (and simply "exclude_tags" in the args to > `_config_get_list' and `_config_set_list', of course). +1 > Unfortunately, this would also partially invalidate your recent NEWS > submission [2]. > > - If the 'search.exclude_tags' option is missing from the config file, > its value is automatically set to "deleted;spam;", which probably isn't > a sane default. Luckily, you've already provided the solution [3]. I am against doing something /unsafe/ in the user's back. If there is no option set intentionnaly by the user, there is nothing notmuch should do -i.e no exclusion - > - To make new users aware of the config option's existence, we should > prompt them to configure it during setup. +1 /Xavier