From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] Fix notmuch_database_get_directory API
Date: Sun, 13 May 2012 23:49:58 +0300 [thread overview]
Message-ID: <m2txzjlsax.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1336939029-13969-1-git-send-email-amdragon@mit.edu>
On Sun, May 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> This is a proposed last-minute change for 0.13. It fixes the
> notmuch_database_get_directory API in the same way we're fixing
> notmuch_database_open, etc in this release. Since this is a
> backwards-incompatible change, it would be nice to lump it with the
> other API-breaking changes.
>
> To keep the patch simple, this does not change the behavior of
> notmuch_database_get_directory, but it puts us in a good position to
> fix it in the future.
Looks good to me (and applied in my current environment). The c/c++
changes were easy to understand and the python/go/ruby binding
changes looks like the old changes -- but those who understand more
(and actually uses those bindings) could do better review.
It would be nice to get those in so that we may have chance not
updating SONAME for notmuch 0.14.
Tomi
next prev parent reply other threads:[~2012-05-13 20:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 19:57 [PATCH 0/5] Fix notmuch_database_get_directory API Austin Clements
2012-05-13 19:57 ` [PATCH 1/5] lib/cli: Make notmuch_database_get_directory return a status code Austin Clements
2012-05-13 19:57 ` [PATCH 2/5] go: Update for changes to notmuch_database_get_directory Austin Clements
2012-05-13 21:51 ` Justus Winter
2012-05-13 23:15 ` Austin Clements
2012-05-13 19:57 ` [PATCH 3/5] python: " Austin Clements
2012-05-13 19:57 ` [PATCH 4/5] ruby: " Austin Clements
2012-05-13 19:57 ` [PATCH 5/5] news: " Austin Clements
2012-05-13 20:49 ` Tomi Ollila [this message]
2012-05-13 21:55 ` [PATCH 0/5] Fix notmuch_database_get_directory API Justus Winter
2012-05-13 23:36 ` [PATCH v2 " Austin Clements
2012-05-13 23:36 ` [PATCH v2 1/5] lib/cli: Make notmuch_database_get_directory return a status code Austin Clements
2012-05-13 23:36 ` [PATCH v2 2/5] go: Update for changes to notmuch_database_get_directory Austin Clements
2012-05-13 23:36 ` [PATCH v2 3/5] python: " Austin Clements
2012-05-13 23:36 ` [PATCH v2 4/5] ruby: " Austin Clements
2012-05-13 23:36 ` [PATCH v2 5/5] news: " Austin Clements
2012-05-15 12:04 ` [PATCH v2 0/5] Fix notmuch_database_get_directory API David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2txzjlsax.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).