From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: fix for failing tests with gmime 2.6.19
Date: Mon, 18 Nov 2013 19:54:52 +0200 [thread overview]
Message-ID: <m2txf9ioib.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1384100482-15453-1-git-send-email-david@tethera.net>
On Sun, Nov 10 2013, David Bremner <david@tethera.net> wrote:
> Although Jeffrey Stedfast fixed gmime bug 711305 amazingly quickly, it
> looks like many people still have to live with a buggy version of
> gmime for a while yet. Here is an opt-in fix that stops the test suite
> from failing; this is a simple fix for e.g. the debian build process.
After looking throught all the comments and thinking about the options
I see the following 2 options
1) Keep things as those currently are. Anyone who runs tests when
gmime 2.6.19 is in use will see some tests fail (and some may not have
a clue what's going on). We could mention this first thing in the NEWS
so that the "professional" users who run test *and* reads NEWS will
get the clue.
2) Push the current patches to release branch *only* (maybe the test
could be changed to if [ pkg-config --exact-version=2.6.19 gmime-2.6 ] (*)
instead of checking the WORKAROUNDS flag so that users would not have
to bother (and some may not have a clue what's going on)). During merge
to master (as it has been done in the past) these changes would probably
be dropped.
2b) Merge to master, release 0.17, follow gmime deployments, revert
patches.
IMHO for temporary problems there could be temporary cruft (which would
not be cruft if the problem wasn't temporary). The test system must
be as strict as it can be to ensure best failure coverage.
Tomi
(*) The fastest (& most cruftiest) implementation:
notmuch_reply_sanitize ()
{
if pkg-config --exact-version=2.6.19 gmime-2.6 >/dev/null
then
notmuch_reply_sanitize () {
# work around GMIME bug #711305
sed -e 's/^References: /References: /'
}
else
notmuch_reply_sanitize () {
cat
}
fi
notmuch_reply_sanitize # call just rewritten version of this function
}
prev parent reply other threads:[~2013-11-18 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 16:21 fix for failing tests with gmime 2.6.19 David Bremner
2013-11-10 16:21 ` [PATCH 1/2] test: add optional workaround for gmime bug David Bremner
2013-11-10 16:21 ` [PATCH 2/2] test: work around gmime bug using notmuch_reply_sanitize David Bremner
2013-11-11 3:15 ` [Patch v2 1/2] test: add optional workaround for gmime bug David Bremner
2013-11-11 3:15 ` [Patch v2 2/2] test: work around gmime bug using notmuch_reply_sanitize David Bremner
2013-11-11 3:47 ` fix for failing tests with gmime 2.6.19 Daniel Kahn Gillmor
2013-11-11 11:57 ` David Bremner
2013-11-11 13:42 ` David Bremner
2013-11-16 20:16 ` Jameson Graef Rollins
2013-11-16 23:00 ` David Bremner
2013-11-11 14:59 ` Tomi Ollila
2013-11-11 16:01 ` Jani Nikula
2013-11-18 17:54 ` Tomi Ollila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2txf9ioib.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).