From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] cli: fix top level --help combined with other options
Date: Tue, 10 Mar 2015 10:03:44 +0200 [thread overview]
Message-ID: <m2twxtb7of.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87egoytzsm.fsf@maritornes.cs.unb.ca>
On Mon, Mar 09 2015, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> - ret = notmuch_help_command (NULL, argc - 1, &argv[1]);
>> + /*
>> + * Pass the first positional argument as argv[1] so the help
>> + * command can give help for it. The help command ignores the
>> + * argv[0] passed to it.
>> + */
>> + ret = notmuch_help_command (NULL, argc - opt_index + 1,
>> + argv + opt_index - 1);
>> goto DONE;
>> }
>
> LGTM
Also to me, too.
Tomi
next prev parent reply other threads:[~2015-03-10 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 16:18 [PATCH 1/2] cli: fix top level --help combined with other options Jani Nikula
2015-03-08 16:18 ` [PATCH 2/2] cli: add support for notmuch command --help Jani Nikula
2015-03-09 7:14 ` David Bremner
2015-03-10 8:06 ` Tomi Ollila
2015-03-09 7:06 ` [PATCH 1/2] cli: fix top level --help combined with other options David Bremner
2015-03-10 8:03 ` Tomi Ollila [this message]
2015-03-11 7:16 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2twxtb7of.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).