From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 055A0429E3B for ; Mon, 16 Jan 2012 13:43:10 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O3C07BMCsbWz for ; Mon, 16 Jan 2012 13:43:09 -0800 (PST) Received: from mail-qw0-f46.google.com (mail-qw0-f46.google.com [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 65A24429E35 for ; Mon, 16 Jan 2012 13:43:09 -0800 (PST) Received: by qadc10 with SMTP id c10so495584qad.5 for ; Mon, 16 Jan 2012 13:43:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:content-transfer-encoding; bh=AQ22L5UbgJWHIa1wGEGRBFG5SVBHDq7xE8htDQINjEg=; b=mq4iUZghZ+B/5MrbUTpCNb586Iv1vPuKUKXBUjXbbldt4EFvAWLTbatXFhGPtdI9JP G7wl6aNXnJMqXBmLzDO0q0dpc+WQkX2x2D/8gB2dDDd9W9DQa5u9mpd8T2vexZmBFPsd Rml53+5C9keBy4STxmQG9vCGnJlK4mOtqULdo= Received: by 10.224.34.196 with SMTP id m4mr16547133qad.66.1326750188779; Mon, 16 Jan 2012 13:43:08 -0800 (PST) Received: from localhost (vpl458.wlan.library.upenn.edu. [130.91.141.203]) by mx.google.com with ESMTPS id co15sm39350934qab.1.2012.01.16.13.43.07 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Jan 2012 13:43:07 -0800 (PST) From: Aaron Ecay To: Pieter Praet , David Edmondson , Jameson Graef Rollins Subject: Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on the target message's state In-Reply-To: <1326733053-25185-1-git-send-email-pieter@praet.org> References: <87hazva8qe.fsf@praet.org> <1326733053-25185-1-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.11+62~ge41b0d3 (http://notmuchmail.org) Emacs/24.0.92.1 (i386-apple-darwin10.8.0) Date: Mon, 16 Jan 2012 16:43:06 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 21:43:10 -0000 On Mon, 16 Jan 2012 17:57:33 +0100, Pieter Praet wrote: > * emacs/notmuch-show.el (notmuch-show-buttonized-link-colors): > new defcustom, allows toggling colorization of buttonized links. >=20 > * emacs/notmuch-show.el (notmuch-show-buttonized-link-present), > * emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unread), > * emacs/notmuch-show.el (notmuch-show-buttonized-link-missing): > new faces for buttonized id: links. >=20 > * emacs/notmuch-show.el (notmuch-show-found-target-p): add optional arg > VERIFY-UNREAD which causes results to be filtered by "tag:unread". >=20 > * emacs/notmuch-show.el (notmuch-show-buttonize-links): use different > face property depending on the result of `notmuch-show-found-target-p', > causing buttons to available, available-and-unread and missing messages > to be displayed in a different color. I really like the idea behind this patch, but it has the very small problem that it colorizes too much. So in reading this thread, there are things like =E2=80=9Cid:=E2=80=99s=E2=80=9D and =E2=80=9Cid:?=E2=80=9D = that get colored the missing-message color (a very angry red, by default). Though this isn=E2=80=99t likely to = be a very frequent problem with email messages that are not on this listserv :), it would be nice to fix it. Maybe you could change the regex that matches id:=E2=80=99s to require a little more structure =E2=80=93 an at-si= gn, perhaps. Or even requiring more than (say) 5 non-space characters after the message id would cut down sharply on the false positive rate. --=20 Aaron Ecay