unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev
@ 2012-02-09 23:20 Daniel Kahn Gillmor
  2012-02-10 13:15 ` David Bremner
  2012-02-28  2:25 ` David Bremner
  0 siblings, 2 replies; 6+ messages in thread
From: Daniel Kahn Gillmor @ 2012-02-09 23:20 UTC (permalink / raw)
  To: Notmuch Mail; +Cc: Daniel Kahn Gillmor

libgmime-2.6-dev entered debian unstable today.  If 2.6 is available,
notmuch should build against 2.6 instead of 2.4, as 2.6 is the current
upstream stable version of libgmime.
---
 debian/control |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/debian/control b/debian/control
index f6f415e..b60790e 100644
--- a/debian/control
+++ b/debian/control
@@ -10,7 +10,7 @@ Build-Depends:
  debhelper (>= 7.0.50~),
  pkg-config,
  libxapian-dev,
- libgmime-2.4-dev,
+ libgmime-2.6-dev | libgmime-2.4-dev,
  libtalloc-dev,
  libz-dev,
  python-all (>= 2.6.6-3~),
-- 
1.7.8.3

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev
  2012-02-09 23:20 [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev Daniel Kahn Gillmor
@ 2012-02-10 13:15 ` David Bremner
  2012-02-10 17:58   ` Daniel Kahn Gillmor
  2012-02-10 20:57   ` Tomi Ollila
  2012-02-28  2:25 ` David Bremner
  1 sibling, 2 replies; 6+ messages in thread
From: David Bremner @ 2012-02-10 13:15 UTC (permalink / raw)
  To: Daniel Kahn Gillmor, Notmuch Mail

On Thu,  9 Feb 2012 18:20:20 -0500, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
> libgmime-2.6-dev entered debian unstable today.  If 2.6 is available,
> notmuch should build against 2.6 instead of 2.4, as 2.6 is the current
> upstream stable version of libgmime.

Hi Daniel;

I'm not necessarily opposed to migrating to the Debian packages to gmime
2.6, but I'd like to point out that your patch is might be more decisive
than intended, since the build daemons strip all but the first
dependency. This will cause the build do fail if 2.6 is not
available. For more discussion of this, see
id:"20110920181701.GQ3245@codelibre.net" (debian-devel, Sept. 2011).

David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev
  2012-02-10 13:15 ` David Bremner
@ 2012-02-10 17:58   ` Daniel Kahn Gillmor
  2012-02-10 20:57   ` Tomi Ollila
  1 sibling, 0 replies; 6+ messages in thread
From: Daniel Kahn Gillmor @ 2012-02-10 17:58 UTC (permalink / raw)
  To: David Bremner; +Cc: Notmuch Mail

On 02/10/2012 08:15 AM, David Bremner wrote:
> I'm not necessarily opposed to migrating to the Debian packages to gmime
> 2.6, but I'd like to point out that your patch is might be more decisive
> than intended, since the build daemons strip all but the first
> dependency. This will cause the build do fail if 2.6 is not
> available. For more discussion of this, see
> id:"20110920181701.GQ3245@codelibre.net" (debian-devel, Sept. 2011).

This doesn't worry me.  gmime 2.6 is already successfully built on all
arches except mipsel and armhf:

 https://buildd.debian.org/status/package.php?p=gmime

i don't think armhf is a blocker at this point (though i've already
followed up with the arm porters about that to see if we can get it
fixed), and mipsel is just typically backlogged (that is, it hasn't
failed, it just hasn't gotten to build yet).

So i don't think switching notmuch over to a 2.6 dependency on the
buildd's would be a hindrance for notmuch.

	--dkg

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev
  2012-02-10 13:15 ` David Bremner
  2012-02-10 17:58   ` Daniel Kahn Gillmor
@ 2012-02-10 20:57   ` Tomi Ollila
  2012-02-10 21:02     ` Daniel Kahn Gillmor
  1 sibling, 1 reply; 6+ messages in thread
From: Tomi Ollila @ 2012-02-10 20:57 UTC (permalink / raw)
  To: David Bremner, Daniel Kahn Gillmor, Notmuch Mail

On Fri, 10 Feb 2012 09:15:53 -0400, David Bremner <david@tethera.net> wrote:
> On Thu,  9 Feb 2012 18:20:20 -0500, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
> > libgmime-2.6-dev entered debian unstable today.  If 2.6 is available,
> > notmuch should build against 2.6 instead of 2.4, as 2.6 is the current
> > upstream stable version of libgmime.
> 
> Hi Daniel;
> 
> I'm not necessarily opposed to migrating to the Debian packages to gmime
> 2.6, but I'd like to point out that your patch is might be more decisive
> than intended, since the build daemons strip all but the first
> dependency. This will cause the build do fail if 2.6 is not
> available. For more discussion of this, see
> id:"20110920181701.GQ3245@codelibre.net" (debian-devel, Sept. 2011).

For the time being, should the order be:

- libgmime-2.4-dev,
+ libgmime-2.4-dev | libgmime-2.6-dev,

?

> 
> David

Tomi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev
  2012-02-10 20:57   ` Tomi Ollila
@ 2012-02-10 21:02     ` Daniel Kahn Gillmor
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Kahn Gillmor @ 2012-02-10 21:02 UTC (permalink / raw)
  To: Tomi Ollila; +Cc: Notmuch Mail

On 02/10/2012 03:57 PM, Tomi Ollila wrote:
> For the time being, should the order be:
> 
> - libgmime-2.4-dev,
> + libgmime-2.4-dev | libgmime-2.6-dev,

2.6 is available and functional in unstable.  I think we should prefer 2.6.

This will enable (and encourage) us to approach S/MIME support too
(which isn't offered in 2.4), as well as helping flush out any concerns
with 2.6.  Leaving 2.4-dev as an optional b-d will make backporting
simpler, but i think we should try to use (and support) upstream's
stable gmime branch.

	--dkg

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev
  2012-02-09 23:20 [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev Daniel Kahn Gillmor
  2012-02-10 13:15 ` David Bremner
@ 2012-02-28  2:25 ` David Bremner
  1 sibling, 0 replies; 6+ messages in thread
From: David Bremner @ 2012-02-28  2:25 UTC (permalink / raw)
  To: Daniel Kahn Gillmor, Notmuch Mail

On Thu,  9 Feb 2012 18:20:20 -0500, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
> libgmime-2.6-dev entered debian unstable today.  If 2.6 is available,
> notmuch should build against 2.6 instead of 2.4, as 2.6 is the current
> upstream stable version of libgmime.

Pushed.

d

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-02-28  2:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-09 23:20 [PATCH] Build-Depend on libgmime-2.6-dev | libgmime2.4-dev Daniel Kahn Gillmor
2012-02-10 13:15 ` David Bremner
2012-02-10 17:58   ` Daniel Kahn Gillmor
2012-02-10 20:57   ` Tomi Ollila
2012-02-10 21:02     ` Daniel Kahn Gillmor
2012-02-28  2:25 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).