unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait
Date: Sat, 04 Aug 2012 10:05:04 +0300	[thread overview]
Message-ID: <m2sjc3rvbz.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20120803205216.GG22601@mit.edu>

On Fri, Aug 03 2012, Austin Clements <amdragon@MIT.EDU> wrote:

> Code LGTM, but maybe the comment should explain that this is a
> workaround for a bug in Emacs, given that both sleep-for and sit-for
> are supposed to process process output and run sentinels (which has
> been stated in the Elisp reference at least as far back as Emacs 21).
> In light of this (and our better understanding of sleep-for and
> sit-for from IRC discussions), the commit message is also misleading.

Indeed...

Tomi

  reply	other threads:[~2012-08-04  7:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 12:16 [PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait Tomi Ollila
2012-08-03 20:52 ` Austin Clements
2012-08-04  7:05   ` Tomi Ollila [this message]
2012-08-04 23:17 ` [PATCH v2] " Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2sjc3rvbz.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=amdragon@MIT.EDU \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).