From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] build: fix out-of-tree builds
Date: Thu, 16 May 2013 15:01:10 +0300 [thread overview]
Message-ID: <m2sj1n6smx.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87hai3dvkm.fsf@zancas.localnet>
On Thu, May 16 2013, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> On Wed, 15 May 2013, David Bremner <david@tethera.net> wrote:
>>> Jani Nikula <jani@nikula.org> writes:
>>>> # List all subdirectories here. Each contains its own Makefile.local
>>>> -subdirs := compat completion emacs lib man parse-time-string
>>>> -subdirs += performance-test util test
>>>> +subdirs = compat completion emacs lib man parse-time-string performance-test util test
>>>
>>> Is this a functional change or a cosmetic one?
>>
>> Functional. All of it seems to be required for out-of-tree builds (*) to
>> work. I'm afraid I've forgotten exactly why both := and += make it fail
>> (I wrote the patch a few months ago).
>>
>
> Still I guess it deserves a comment so we don't break it again?
The following options could be tested (some day in (distant?) future):
subdirs = compat completion emacs lib man parse-time-string
subdirs += performance-test util test
or
SUBDIRS := compat completion emacs lib man parse-time-string
SUBDIRS += performance-test util test
subdirs = $(SUBDIRS)
but as Jani has already tested his version works just adding that
comment David asked is the least labor-intensive thing to do --
and therefore IMHO the best thing to do for this case
(for sure I'm not going to spend more time on this now :D).
> d
Tomi
next prev parent reply other threads:[~2013-05-16 12:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 10:58 [PATCH] build: fix out-of-tree builds Jani Nikula
2013-05-15 15:40 ` David Bremner
2013-05-15 16:31 ` Jani Nikula
2013-05-16 11:15 ` David Bremner
2013-05-16 12:01 ` Tomi Ollila [this message]
2013-05-25 11:18 ` [PATCH v2] " Jani Nikula
2013-05-26 11:34 ` Tomi Ollila
2013-05-26 23:37 ` David Bremner
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 21:34 [PATCH] " Jani Nikula
2013-03-08 4:03 ` David Bremner
2013-03-08 6:26 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sj1n6smx.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).