From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ali Polatel <polatel@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()
Date: Tue, 21 May 2013 17:59:31 +0300 [thread overview]
Message-ID: <m2sj1g4bvw.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20130521144659.GA6002@hayalet>
On Tue, May 21 2013, Ali Polatel <polatel@gmail.com> wrote:
> 2013/05/21 Tomi Ollila <tomi.ollila@iki.fi>:
>>On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>>
>>> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are
>>> loaded lazily, so nobody would notice unless they try
>>> 'query::count_messages'.
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>
>>This patch could be pushed on it's own, but someone (like Ali) could
>>comment on the change as searches on both UINT2FIX() & UINT2NUM()
>>provides (IMH) insatisfactory results...
>
> LGTM.
>
> My bad, there's no such thing as UINT2FIX().
> Yet, what's wrong with UINT2NUM()?
Nothing wrong -- although it seems obvious UINT2NUM() is the right thing
to do I was not qualified to say so...
>
> The description looks like:
> "...take an unsigned int and convert it to a FIXNUM object if it will fit;
> otherwise, convert to a Bignum object..."
... as I did not find this description when browsing the search results
(now this was in the first search result -- sometimes one just doesn't
get the right search terms in place)...
>
> Besides ruby-1.8 has it and that's the oldest version I was willing to
> support. (If you have some free time, please confirm this because I may
> not be remembering correctly.)
Cannot confirm for sure -- I found references to UINT2NUM() and ruby
1.8.6...
.. anyway UINT2FIX() doesn't work and UINT2NUM() works with very high
probablility I'd say lets get this pushed.
"Hey, it compiles! Ship It !"
>
>>Tomi
>
> -alip
Tomi
prev parent reply other threads:[~2013-05-21 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 12:24 [PATCH 0/2] ruby: general improvements Felipe Contreras
2013-05-20 12:24 ` [PATCH 1/2] ruby: use in-tree notmuch library Felipe Contreras
2013-05-20 14:41 ` David Bremner
2013-05-20 22:24 ` Felipe Contreras
2013-05-23 11:44 ` David Bremner
2013-05-20 12:24 ` [PATCH 2/2] ruby: fix missing symbol UINT2FIX() Felipe Contreras
2013-05-21 14:17 ` Tomi Ollila
2013-05-21 14:46 ` Ali Polatel
2013-05-21 14:59 ` Tomi Ollila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sj1g4bvw.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
--cc=polatel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).