unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: Make symbol-test depend on libnotmuch.so
@ 2013-08-13 19:52 Austin Clements
  2013-08-14  6:23 ` Tomi Ollila
  2013-08-15  9:41 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: Austin Clements @ 2013-08-13 19:52 UTC (permalink / raw)
  To: notmuch

Without this
$ make -j test
intermittently fails and
$ make clean; make test/symbol-test
always fails (not that anybody would do the latter).
---
 test/Makefile.local |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/Makefile.local b/test/Makefile.local
index 2ec6595..8870ca3 100644
--- a/test/Makefile.local
+++ b/test/Makefile.local
@@ -27,7 +27,7 @@ $(dir)/random-corpus: $(random_corpus_deps)
 $(dir)/smtp-dummy: $(smtp_dummy_modules)
 	$(call quiet,CC) $^ -o $@
 
-$(dir)/symbol-test: $(dir)/symbol-test.o
+$(dir)/symbol-test: $(dir)/symbol-test.o lib/$(LINKER_NAME)
 	$(call quiet,CXX) $^ -o $@ -Llib -lnotmuch $(XAPIAN_LDFLAGS)
 
 $(dir)/parse-time: $(dir)/parse-time.o parse-time-string/parse-time-string.o
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: Make symbol-test depend on libnotmuch.so
  2013-08-13 19:52 [PATCH] test: Make symbol-test depend on libnotmuch.so Austin Clements
@ 2013-08-14  6:23 ` Tomi Ollila
  2013-08-15  9:41 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2013-08-14  6:23 UTC (permalink / raw)
  To: Austin Clements, notmuch

On Tue, Aug 13 2013, Austin Clements <amdragon@MIT.EDU> wrote:

> Without this
> $ make -j test
> intermittently fails and
> $ make clean; make test/symbol-test
> always fails (not that anybody would do the latter).
> ---

LGTM.

Tomi

>  test/Makefile.local |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/Makefile.local b/test/Makefile.local
> index 2ec6595..8870ca3 100644
> --- a/test/Makefile.local
> +++ b/test/Makefile.local
> @@ -27,7 +27,7 @@ $(dir)/random-corpus: $(random_corpus_deps)
>  $(dir)/smtp-dummy: $(smtp_dummy_modules)
>  	$(call quiet,CC) $^ -o $@
>  
> -$(dir)/symbol-test: $(dir)/symbol-test.o
> +$(dir)/symbol-test: $(dir)/symbol-test.o lib/$(LINKER_NAME)
>  	$(call quiet,CXX) $^ -o $@ -Llib -lnotmuch $(XAPIAN_LDFLAGS)
>  
>  $(dir)/parse-time: $(dir)/parse-time.o parse-time-string/parse-time-string.o
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: Make symbol-test depend on libnotmuch.so
  2013-08-13 19:52 [PATCH] test: Make symbol-test depend on libnotmuch.so Austin Clements
  2013-08-14  6:23 ` Tomi Ollila
@ 2013-08-15  9:41 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2013-08-15  9:41 UTC (permalink / raw)
  To: Austin Clements, notmuch

Austin Clements <amdragon@MIT.EDU> writes:

> Without this
> $ make -j test
> intermittently fails and
> $ make clean; make test/symbol-test
> always fails (not that anybody would do the latter).

pushed,

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-08-15  9:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-13 19:52 [PATCH] test: Make symbol-test depend on libnotmuch.so Austin Clements
2013-08-14  6:23 ` Tomi Ollila
2013-08-15  9:41 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).