From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] Move pick to use prefix-arg rather than Escape
Date: Tue, 01 Oct 2013 11:50:22 +0300 [thread overview]
Message-ID: <m2siwlgysx.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1379965979-14752-1-git-send-email-markwalters1009@gmail.com>
On Mon, Sep 23 2013, Mark Walters <markwalters1009@gmail.com> wrote:
> To try and minimise the impact of pick on the code base some
> keybindings which would naturally use a prefix argument were done as a
> separate keybinding with "M-". (The reason is that a prefix argument
> would have meant modifying the original function whereas the M- could
> be bound to a new function in pick)
>
> The first patch is actually all inside pick anyway so can be
> changed. The second patch removes a different occurence of the M-
> keybinding temporarily: we can add back the prefix-arg version once
> pick is in mainline.
>
> I also have some patches to add the prefix-argument (going to pick) to
> hello buttons and other search entry points. (I think this is a good
> reason to make the change from M- to prefix-arg as it is much easier
> to link the prefix-arg into button actions).
LGTM.
Tomi
>
> Best wishes
>
> Mark
>
> Mark Walters (2):
> contrib: pick: move M-RET to prefix-arg RET
> contrib: pick: remove temporary keybinding
>
> contrib/notmuch-pick/notmuch-pick.el | 52 +++++++++++++---------------------
> 1 files changed, 20 insertions(+), 32 deletions(-)
>
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-10-01 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 19:52 [PATCH 0/2] Move pick to use prefix-arg rather than Escape Mark Walters
2013-09-23 19:52 ` [PATCH 1/2] contrib: pick: move M-RET to prefix-arg RET Mark Walters
2013-09-23 19:52 ` [PATCH 2/2] contrib: pick: remove temporary keybinding Mark Walters
2013-10-01 8:50 ` Tomi Ollila [this message]
2013-10-02 11:49 ` [PATCH 0/2] Move pick to use prefix-arg rather than Escape David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2siwlgysx.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).