From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: remove redundant 'file' command from gdb scripts.
Date: Mon, 01 Jun 2015 12:02:54 +0300 [thread overview]
Message-ID: <m2siabby2p.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1433091554-31483-1-git-send-email-david@tethera.net>
On Sun, May 31 2015, David Bremner <david@tethera.net> wrote:
> Quoting Debian bug 787341
>
> It failed to build on arm64: the last ten tests in T070-insert
> failed.
>
> What's happening here is that GDB is segfaulting in response to
> the
> "file" command. GDB on arm64 can be a bit buggy.
>
> However, the "file" command is redundant here as GDB has already
> got
> the file from the --args on the command line.
> ---
looks trivial enough to me...
> test/T070-insert.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/test/T070-insert.sh b/test/T070-insert.sh
> index 168345c..74f1955 100755
> --- a/test/T070-insert.sh
> +++ b/test/T070-insert.sh
> @@ -191,7 +191,6 @@ for code in OUT_OF_MEMORY XAPIAN_EXCEPTION FILE_NOT_EMAIL \
> READ_ONLY_DATABASE UPGRADE_REQUIRED; do
> gen_insert_msg
> cat <<EOF > index-file-$code.gdb
> -file notmuch
> set breakpoint pending on
> break notmuch_database_add_message
> commands
> --
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2015-06-01 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-31 16:59 [PATCH] test: remove redundant 'file' command from gdb scripts David Bremner
2015-06-01 9:02 ` Tomi Ollila [this message]
2015-06-02 2:58 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2siabby2p.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).