* message-default-mail-headers not working in notmuch 0.22
@ 2016-04-29 13:54 Sebastian Fischmeister
2016-04-29 14:33 ` David Edmondson
2016-04-29 14:44 ` David Bremner
0 siblings, 2 replies; 5+ messages in thread
From: Sebastian Fischmeister @ 2016-04-29 13:54 UTC (permalink / raw)
To: Notmuch Mail
Hi,
After upgrading to notmuch 0.22, my emacs config seems broken:
(setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
When creating a new mail, it has no header other than "To:" and
"Subject:".
Since I cannot find any item in the NEWS related to this release, is
this expected behaviour?
Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: message-default-mail-headers not working in notmuch 0.22
2016-04-29 13:54 message-default-mail-headers not working in notmuch 0.22 Sebastian Fischmeister
@ 2016-04-29 14:33 ` David Edmondson
2016-04-29 20:55 ` Sebastian Fischmeister
2016-05-01 8:38 ` Michal Sojka
2016-04-29 14:44 ` David Bremner
1 sibling, 2 replies; 5+ messages in thread
From: David Edmondson @ 2016-04-29 14:33 UTC (permalink / raw)
To: sfischme, Notmuch Mail
On Fri, Apr 29 2016, Sebastian Fischmeister wrote:
> After upgrading to notmuch 0.22, my emacs config seems broken:
>
> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
>
> When creating a new mail, it has no header other than "To:" and
> "Subject:".
>
> Since I cannot find any item in the NEWS related to this release, is
> this expected behaviour?
No, it's not intended. Please try this patch:
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 0445975..399e138 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -338,7 +338,10 @@ modified. This function is notmuch addaptation of
;; We need to convert any string input, eg from rmail-start-mail.
(dolist (h other-headers other-headers)
(if (stringp (car h)) (setcar h (intern (capitalize (car h))))))))
- (args (list yank-action send-actions)))
+ (args (list yank-action send-actions))
+ ;; Cause `message-setup-1' to do things relevant for mail,
+ ;; such as observe `message-default-mail-headers'.
+ (message-this-is-mail t))
;; message-setup-1 in Emacs 23 does not accept return-action
;; argument. Pass it only if it is supplied by the caller. This
;; will never be the case when we're called by `compose-mail' in
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: message-default-mail-headers not working in notmuch 0.22
2016-04-29 14:33 ` David Edmondson
@ 2016-04-29 20:55 ` Sebastian Fischmeister
2016-05-01 8:38 ` Michal Sojka
1 sibling, 0 replies; 5+ messages in thread
From: Sebastian Fischmeister @ 2016-04-29 20:55 UTC (permalink / raw)
To: David Edmondson, Notmuch Mail
I can confirm that this fixes the problem.
Thanks for the quick reply!
Sebastian
David Edmondson <dme@dme.org> writes:
> On Fri, Apr 29 2016, Sebastian Fischmeister wrote:
>> After upgrading to notmuch 0.22, my emacs config seems broken:
>>
>> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
>>
>> When creating a new mail, it has no header other than "To:" and
>> "Subject:".
>>
>> Since I cannot find any item in the NEWS related to this release, is
>> this expected behaviour?
>
> No, it's not intended. Please try this patch:
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 0445975..399e138 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -338,7 +338,10 @@ modified. This function is notmuch addaptation of
> ;; We need to convert any string input, eg from rmail-start-mail.
> (dolist (h other-headers other-headers)
> (if (stringp (car h)) (setcar h (intern (capitalize (car h))))))))
> - (args (list yank-action send-actions)))
> + (args (list yank-action send-actions))
> + ;; Cause `message-setup-1' to do things relevant for mail,
> + ;; such as observe `message-default-mail-headers'.
> + (message-this-is-mail t))
> ;; message-setup-1 in Emacs 23 does not accept return-action
> ;; argument. Pass it only if it is supplied by the caller. This
> ;; will never be the case when we're called by `compose-mail' in
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: message-default-mail-headers not working in notmuch 0.22
2016-04-29 14:33 ` David Edmondson
2016-04-29 20:55 ` Sebastian Fischmeister
@ 2016-05-01 8:38 ` Michal Sojka
1 sibling, 0 replies; 5+ messages in thread
From: Michal Sojka @ 2016-05-01 8:38 UTC (permalink / raw)
To: David Edmondson, sfischme, Notmuch Mail
On Fri, Apr 29 2016, David Edmondson wrote:
> On Fri, Apr 29 2016, Sebastian Fischmeister wrote:
>> After upgrading to notmuch 0.22, my emacs config seems broken:
>>
>> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
>>
>> When creating a new mail, it has no header other than "To:" and
>> "Subject:".
>>
>> Since I cannot find any item in the NEWS related to this release, is
>> this expected behaviour?
>
> No, it's not intended. Please try this patch:
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 0445975..399e138 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -338,7 +338,10 @@ modified. This function is notmuch addaptation of
> ;; We need to convert any string input, eg from rmail-start-mail.
> (dolist (h other-headers other-headers)
> (if (stringp (car h)) (setcar h (intern (capitalize (car h))))))))
> - (args (list yank-action send-actions)))
> + (args (list yank-action send-actions))
> + ;; Cause `message-setup-1' to do things relevant for mail,
> + ;; such as observe `message-default-mail-headers'.
> + (message-this-is-mail t))
Yes, this seems to be reasonable thing to do. Thanks.
-Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: message-default-mail-headers not working in notmuch 0.22
2016-04-29 13:54 message-default-mail-headers not working in notmuch 0.22 Sebastian Fischmeister
2016-04-29 14:33 ` David Edmondson
@ 2016-04-29 14:44 ` David Bremner
1 sibling, 0 replies; 5+ messages in thread
From: David Bremner @ 2016-04-29 14:44 UTC (permalink / raw)
To: sfischme, Notmuch Mail
Sebastian Fischmeister <sfischme@uwaterloo.ca> writes:
> Hi,
>
> After upgrading to notmuch 0.22, my emacs config seems broken:
>
> (setq message-default-mail-headers "Reply-to: me@example.com\nBcc: me@example.com")
>
> When creating a new mail, it has no header other than "To:" and
> "Subject:".
>
> Since I cannot find any item in the NEWS related to this release, is
> this expected behaviour?
Looks like this problem was introduced in commit 570c0aeb40bd.
Confusingly it looks like it has something to do with the different
handling of "message-default-headers" and "message-default-mail-headers"
in message-setup-1.
d
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-01 8:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-29 13:54 message-default-mail-headers not working in notmuch 0.22 Sebastian Fischmeister
2016-04-29 14:33 ` David Edmondson
2016-04-29 20:55 ` Sebastian Fischmeister
2016-05-01 8:38 ` Michal Sojka
2016-04-29 14:44 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).