From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2KlGAJaoCWEB/gAAgWs5BA (envelope-from ) for ; Tue, 03 Aug 2021 22:35:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SJd6N5WoCWGwIQAAB5/wlQ (envelope-from ) for ; Tue, 03 Aug 2021 20:35:33 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3EB6F28331 for ; Tue, 3 Aug 2021 22:35:33 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B4A192C0AA; Tue, 3 Aug 2021 16:35:29 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id B41542C0A8 for ; Tue, 3 Aug 2021 16:35:26 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id A84101B000A5; Tue, 3 Aug 2021 23:35:24 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1628022924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iI0oaG+aci57R4q4Siq6DVYms72o1HEdyuuICRMY7KQ=; b=XC99qWGUl9XPaTvPaw8tiX7QekFhb8rXXW4zvruxjjBFCiBrC1aL+LOqWTTnQa+fZ3ATSy /Y8JxbEDWN0E0P2lL4j1Axz4DVyEaYDL54aNEpzaadM2+ka8421/aqgjjS6vqJC76ALVoJ sbgCUhjbg6JihD+Sb6YNS+jcmASUAXMhQro582tQokHRMvO4bEpVXeOS66AYtN5CAgMhqP ljKqyh3ZHEvHSLNn/W79epePsb3aVzcPrqde5LNH1qjzoTfiWOAe7W+o5nJlozpRsifDGU UHlQS3kYAG7as9LTqF6AC81GU9wDwxDWrlJrRieOFOn5ikfPTfic18eKXK8pRA== From: Tomi Ollila To: Matt Armstrong , notmuch@notmuchmail.org Subject: Re: [PATCH] Fix author-scan.sh on BSD systems. In-Reply-To: <20210213182243.94288-1-matt@rfc20.org> References: <20210213182243.94288-1-matt@rfc20.org> User-Agent: Notmuch/0.32+21~gfdddd4c (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1628022924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iI0oaG+aci57R4q4Siq6DVYms72o1HEdyuuICRMY7KQ=; b=SWfujkL4jIoW+gg4XY/1yC6dV88HFG3UQZVmFqiT/X9/Z8WS72QzuTa9b9oQnuAFIAfkWQ GL+p9hBE9YydCB/wBkssn8dWKD6RDXTSLnL2ctauYAnVmNyK3SpX3DzwmkyJFQQRdj9Tzd 1+bZHFdRbLUgtEKG5ZLQNp/8N1h28B5PI+Df61kKeuwlZpDVGgHSFPk5IDhbHY2Mr89DGa GopZh/HOP+Mlw6Njrr4HNl1R3c1qHBanMuOY+ajacikwmcmcZTi+ZU74c5vp9ZEMn9r+YZ xZI8WJGwNeWAeTYSAP2GfWwfjIhiqqIzwhsRBfv3vW/OFJWFX1gEMoXKkrWTTA== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1628022924; a=rsa-sha256; cv=none; b=JFofp1dRFjhaTC8euw7mxzXkAchyX5Lr6XpIAI9Sih5bxwKn714YGuQKH/EUgCKYaEF+7I eFdmQ7fJbXOJnbS4zEedCvoq++my4zTBTutYD9lxnUZU2oNcHZRr3K2mUYKA3YnUBoEK7o O5rQ4WYE1LtREM3LjQGONNXcEBgKSqlcOL//mgbD3J/fVIWVV6407PSblLY+SZMSFygvnR 4Z7Wt78x4IbLY2tpARGjXazaUMvf7YReMBiNkT7d+05bilqoXF23PQJkCmnN/e6HYXVD/v onZuox2q8lb7kpEuwxjp3DFQr2BCP3CvuLDoXpjzEL2CA/AVdCdEDFjWMOSBZQ== Message-ID-Hash: RB3EMDOW7HOSXQT7OWAUYEIZNO2J6SXR X-Message-ID-Hash: RB3EMDOW7HOSXQT7OWAUYEIZNO2J6SXR X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628022933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=vjknsz7gc27m5Bqi9wVCiWcu3briHXgjSuJh5UOce+A=; b=JGd0POAoonQ0m7T+XSkcT+rV+rPhjdC8hBWjfaLi/oKx8EqiYC0+mDdU9XdRCXjzvGa2l4 2HKA9milRooedN9UU7oJWJ9O/poCDe7PQgilPk+qRtsmo+iPG6G0sGxK6P0b1lKVLLxwGS 6zfWPTJFhBTos4SOL4rbac4MmtOlnsPdPhrRPLT8/4YFQEfAgSc966m/eue9q5LBbr2kgT ig/2yJLh07v+TVT6h+i/mwA/z5GKwhXnVPge5SccZk8qb6LN1Ei2+Wi3U07msZR2FyBNKS 1RcDG7hclFi/YeHtdS1aaLlKsRBH9J5A5TKNONOeXdV+BqI8pYVsDtu9ezfNug== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1628022933; a=rsa-sha256; cv=fail; b=OASXBPcTRFp0ZsVcVuWUbV4R8NNBjexMBYDfAEWdZHighigbADKV3qh5Lvwzn9QRuAV75J nVPbNM1UsB0uH1QgqYt0pQxeNhlarSXK7FjGrPD7zR2u5bCb/xUs3sxsw4wRpx0YnE8XGl NEM0XkNX4KHYfVdvRYYhcu9LJ7JY6qMV8MRFnHXHKW/JrXPl0Xqlw/HRXhKpcZPenuMBzg M7BhZnKZbW6HFsrWE6AcoOTnLgRZzpPSJM1KbRpUSwCjcHqOFezzQ8elB2Tv8rFTkRJDRN xZFuuEBpGp56TgQrXiSl2jtn7nHuJAksiFF0fEP2UIi0/9hsuPjpGJQiqTNsKg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=XC99qWGU; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=XC99qWGU; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 3EB6F28331 X-Spam-Score: 0.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: Bf79Ujo1kCfA On Sat, Feb 13 2021, Matt Armstrong wrote: > BSD xargs does not have the -d option. Here we use tr to convert > newlines to NUL characters, then pass -0 to xargs (which BSD does > support). > > I looked at passing -z to 'git ls-files', but I did not find a BSD > grep option to turn on NUL deliminted line processing. > --- > devel/author-scan.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devel/author-scan.sh b/devel/author-scan.sh > index 2d9c4af8..23854f39 100644 > --- a/devel/author-scan.sh > +++ b/devel/author-scan.sh > @@ -5,7 +5,7 @@ AUTHOR_EXCLUDE='uncrustify' > # based on the FSF guideline, for want of a better idea. > THRESHOLD=15 > > -git ls-files | grep -v -e "$FILE_EXCLUDE" | xargs -n 1 -d \\n \ > +git ls-files | grep -v -e "$FILE_EXCLUDE" | tr '\n' '\0' | xargs -0 -n 1 \ LGTM. David will know if this works for the task this is needed :D Tomi > git blame -w --line-porcelain -- | \ > sed -n "/$AUTHOR_EXCLUDE/d; s/^[aA][uU][tT][hH][Oo][rR] //p" | \ > sort -fd | uniq -ic | awk "\$1 >= $THRESHOLD" | sort -nr > -- > 2.30.0