From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch-mutt: use --format=text0 and xargs -0
Date: Thu, 01 Mar 2018 21:01:09 +0200 [thread overview]
Message-ID: <m2r2p37h8q.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <m2y3jdf8iw.fsf@guru.guru-group.fi>
On Wed, Feb 28 2018, Tomi Ollila wrote:
> On Tue, Feb 27 2018, Jani Nikula wrote:
>
>> On Tue, 27 Feb 2018, Jani Nikula <jani@nikula.org> wrote:
>>> notmuch-mutt fails for message files with special characters such as
>>> single quote in their filename. Use notmuch search --format=text0 and
>>> xargs -0 combo to handle them.
>>>
>>> Reported and tested by "dob1" on IRC.
>>> ---
>>> contrib/notmuch-mutt/notmuch-mutt | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt
>>> index 0e46a8c1b95e..57f13075aa22 100755
>>> --- a/contrib/notmuch-mutt/notmuch-mutt
>>> +++ b/contrib/notmuch-mutt/notmuch-mutt
>>> @@ -48,9 +48,9 @@ sub search($$$) {
>>> }
>>>
>>> empty_maildir($maildir);
>>> - system("notmuch search --output=files $dup_option $query"
>>> + system("notmuch search --format=text0 --output=files $dup_option $query"
>>> . " | sed -e 's: :\\\\ :g'"
>>
>> Come to think of it, does this need sed -z too?
>
> it looks to me that sed can be dropped.
>
> btw how many non-coreutils xargs support -0 option ?
Checked (briefly):
openbsd, netbsd, macos and solaris xargs(1) (latest versions...) know -0 option.
so
system("notmuch search --format=text0 --output=files $dup_option $query"
. " | xargs -0 -r -I searchoutput ln -s searchoutput $maildir/cur/");
should be supported enough.
Tomi
prev parent reply other threads:[~2018-03-01 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 19:57 [PATCH] notmuch-mutt: use --format=text0 and xargs -0 Jani Nikula
2018-02-27 20:02 ` Jani Nikula
2018-02-28 15:17 ` Tomi Ollila
2018-03-01 19:01 ` Tomi Ollila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r2p37h8q.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).