From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id D28286DE1444 for ; Mon, 20 May 2019 11:55:10 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.433 X-Spam-Level: X-Spam-Status: No, score=0.433 tagged_above=-999 required=5 tests=[AWL=-0.219, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7WOYrfkZTuJJ for ; Mon, 20 May 2019 11:55:09 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 651D36DE1430 for ; Mon, 20 May 2019 11:55:07 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 7A1661000D0; Mon, 20 May 2019 21:55:05 +0300 (EEST) From: Tomi Ollila To: Daniel Kahn Gillmor , David Bremner , notmuch@notmuchmail.org Subject: Re: parallel tests broken on Debian stable In-Reply-To: <878sv1avfc.fsf@fifthhorseman.net> References: <87ef56io5d.fsf@tethera.net> <878sv1avfc.fsf@fifthhorseman.net> User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2019 18:55:10 -0000 On Mon, May 20 2019, Daniel Kahn Gillmor wrote: > Thanks for catching this, Bremner. > > On Fri 2019-05-10 07:45:18 -0300, David Bremner wrote: >> In a debian stretch neither gnu parallel nor moreutils parallel >> successfully completes the tests. > > I have confirmed this misbehavior on debian stretch with moreutils > parallel. on stretch (with gmime 3.0 from stretch-backports), the tests > complete successfully in serial, but with moreutils parallel installed > they consume the full 2 minutes and then time out, but they time out > without failing explicitly. > >> But the real question is why the jobs don't complete within a 2 minute >> timeout. > > i agree, this is a serious issue, though we should also ensure that > timed-out tests count as failures. > > So there are three things to fix: > > a) when a timeout hits, the test suite should explicitly fail, even if > no individual tests have failed. > > b) we should have a clearer sense of which tests completed and which > did not > > c) we should avoid the timeout hanging :) > > > Looking at the output of "ps" during the hanging test suite, it appears > that parallel is getting blocked by running: T050, T060, T070, T080 (i'm > using a 4-core machine). > > I've just sent two patches to the list that aim for part (a), and i'm > going to work on part (c) on stable now. if someone else wants to > improve the test suite to handle (b) that would be great. Simplest would be that after ./notmuch-test --debug exits, test-results/ would still exist :D > > --dkg Tomi