From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: parallel tests broken on Debian stable
Date: Mon, 20 May 2019 21:55:05 +0300 [thread overview]
Message-ID: <m2r28t6jna.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <878sv1avfc.fsf@fifthhorseman.net>
On Mon, May 20 2019, Daniel Kahn Gillmor wrote:
> Thanks for catching this, Bremner.
>
> On Fri 2019-05-10 07:45:18 -0300, David Bremner wrote:
>> In a debian stretch neither gnu parallel nor moreutils parallel
>> successfully completes the tests.
>
> I have confirmed this misbehavior on debian stretch with moreutils
> parallel. on stretch (with gmime 3.0 from stretch-backports), the tests
> complete successfully in serial, but with moreutils parallel installed
> they consume the full 2 minutes and then time out, but they time out
> without failing explicitly.
>
>> But the real question is why the jobs don't complete within a 2 minute
>> timeout.
>
> i agree, this is a serious issue, though we should also ensure that
> timed-out tests count as failures.
>
> So there are three things to fix:
>
> a) when a timeout hits, the test suite should explicitly fail, even if
> no individual tests have failed.
>
> b) we should have a clearer sense of which tests completed and which
> did not
>
> c) we should avoid the timeout hanging :)
>
>
> Looking at the output of "ps" during the hanging test suite, it appears
> that parallel is getting blocked by running: T050, T060, T070, T080 (i'm
> using a 4-core machine).
>
> I've just sent two patches to the list that aim for part (a), and i'm
> going to work on part (c) on stable now. if someone else wants to
> improve the test suite to handle (b) that would be great.
Simplest would be that after ./notmuch-test --debug exits, test-results/
would still exist :D
>
> --dkg
Tomi
next prev parent reply other threads:[~2019-05-20 18:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 10:45 parallel tests broken on Debian stable David Bremner
2019-05-20 17:27 ` Daniel Kahn Gillmor
2019-05-20 18:55 ` Tomi Ollila [this message]
2019-05-20 21:45 ` Daniel Kahn Gillmor
2019-05-20 23:49 ` Daniel Kahn Gillmor
2019-05-21 0:44 ` Daniel Kahn Gillmor
2019-05-21 1:03 ` [PATCH] test: avoid hanging older gdb under GNU timeout and moreutils parallel Daniel Kahn Gillmor
2019-05-21 2:32 ` David Bremner
2019-05-21 15:45 ` Daniel Kahn Gillmor
2019-05-21 6:12 ` Tomi Ollila
2019-05-21 15:50 ` Daniel Kahn Gillmor
2019-05-21 20:23 ` Tomi Ollila
2021-10-30 19:30 ` parallel tests broken on Debian stable David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r28t6jna.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).