[PATCH] emacs: use def instead of initial-input for notmuch-show-browse-urls

[PATCH] emacs: use def instead of initial-input for notmuch-show-browse-urls

[Keegan Carruthers-Smith]

This is the non-deprecated way to use completing-read. Additionally
the old use was broken when using ivy for completing-read. For user's
using completing-read-default they won't see the default URL now, but
if they hit enter it will be visited. Alternatively they can select
it with M-n.

From the completing-read documentation for initial-input:

 This feature is deprecated--it is best to pass nil for INITIAL-INPUT
 and supply the default value DEF instead.  The user can yank the
 default value into the minibuffer easily using M-n.

Additionally collection is now all urls, rather than all but the
first. I'm not sure why "(cdr urls)" was previously done.
---
 emacs/notmuch-show.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 214e279f..079281c3 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -2559,7 +2559,7 @@ browsing."
 	(prompt (if kill "Copy URL to kill ring: " "Browse URL: "))
 	(fn (if kill #'kill-new #'browse-url)))
     (if urls
-	(funcall fn (completing-read prompt (cdr urls) nil nil (car urls)))
+	(funcall fn (completing-read prompt urls nil nil nil nil (car urls)))
       (message "No URLs found."))))
 
 (provide 'notmuch-show)
-- 
2.26.0

Re: [PATCH] emacs: use def instead of initial-input for notmuch-show-browse-urls

[David Edmondson]

On Monday, 2020-04-13 at 21:58:19 +02, Keegan Carruthers-Smith wrote:

> This is the non-deprecated way to use completing-read. Additionally
> the old use was broken when using ivy for completing-read. For user's
> using completing-read-default they won't see the default URL now, but
> if they hit enter it will be visited. Alternatively they can select
> it with M-n.
>
> From the completing-read documentation for initial-input:
>
>  This feature is deprecated--it is best to pass nil for INITIAL-INPUT
>  and supply the default value DEF instead.  The user can yank the
>  default value into the minibuffer easily using M-n.
>
> Additionally collection is now all urls, rather than all but the
> first. I'm not sure why "(cdr urls)" was previously done.

Reviewed-by: David Edmondson <dme@dme.org>

> ---
>  emacs/notmuch-show.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 214e279f..079281c3 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -2559,7 +2559,7 @@ browsing."
>  	(prompt (if kill "Copy URL to kill ring: " "Browse URL: "))
>  	(fn (if kill #'kill-new #'browse-url)))
>      (if urls
> -	(funcall fn (completing-read prompt (cdr urls) nil nil (car urls)))
> +	(funcall fn (completing-read prompt urls nil nil nil nil (car urls)))
>        (message "No URLs found."))))
>  
>  (provide 'notmuch-show)
> -- 
> 2.26.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

dme.
-- 
I used to worry, thought I was goin' mad in a hurry.

Re: [PATCH] emacs: use def instead of initial-input for notmuch-show-browse-urls

[David Bremner]

Keegan Carruthers-Smith <keegan.csmith@gmail.com> writes:

> This is the non-deprecated way to use completing-read. Additionally
> the old use was broken when using ivy for completing-read. For user's
> using completing-read-default they won't see the default URL now, but
> if they hit enter it will be visited. Alternatively they can select
> it with M-n.

pushed,

d