From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 11A20431FB6
	for <notmuch@notmuchmail.org>; Thu, 14 Jun 2012 12:04:50 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6FniGgvx646G for <notmuch@notmuchmail.org>;
	Thu, 14 Jun 2012 12:04:48 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 892D7431FAE
	for <notmuch@notmuchmail.org>; Thu, 14 Jun 2012 12:04:48 -0700 (PDT)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id 333721000D0; Thu, 14 Jun 2012 22:04:58 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCHv2] emacs: derive correct timestamp in FCC unique name
In-Reply-To: <87y5npg6gc.fsf@jhu.edu>
References: <87d353ezyw.fsf@jhu.edu> <87y5npg6gc.fsf@jhu.edu>
User-Agent: Notmuch/0.13.2+7~g2fb5bbc (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-redhat-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 14 Jun 2012 22:04:58 +0300
Message-ID: <m2pq91iujp.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2012 19:04:50 -0000

On Thu, Jun 14 2012, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:

> Previously, the timestamp at the beginning of the FCC unique maildir
> name was derived incorrectly, thanks to an integer overflow. This
> changes the derivation of timestamp to use a float, and so will get
> the number correct at least until 2038. (It is still formatted with
> "%d" so it will show up as an integer.) Should we need to change it in
> the next 26 years to take the unix millenium into account, it will be
> invisible to users.
>
> This change is mostly a question of consistency, since the unique name
> is arbitrary anyway. But since most people use timestamps, and that was
> the original intention here as well, we might as well.
>
> Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>
> ---


+1


Tomi

>  emacs/notmuch-maildir-fcc.el |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
> index dcfbc4b..07eedba 100644
> --- a/emacs/notmuch-maildir-fcc.el
> +++ b/emacs/notmuch-maildir-fcc.el
> @@ -140,13 +140,12 @@ will NOT be removed or replaced."
>  			    t))
>  
>  (defun notmuch-maildir-fcc-make-uniq-maildir-id ()
> -   (let* ((ct (current-time))
> -	  (timeid (+ (* (car ct) 65536) (cadr ct)))
> -	  (microseconds (car (cdr (cdr ct))))
> +   (let* ((ftime (float-time))
> +	  (microseconds (mod (* 1000000 ftime) 1000000))
>  	  (hostname (notmuch-maildir-fcc-host-fixer system-name)))
>       (setq notmuch-maildir-fcc-count (+ notmuch-maildir-fcc-count 1))
>       (format "%d.%d_%d_%d.%s"
> -	     timeid
> +	     ftime
>  	     (emacs-pid)
>  	     microseconds
>  	     notmuch-maildir-fcc-count
> -- 
> 1.7.9.5
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch