From: Tomi Ollila <tomi.ollila@iki.fi>
To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/7] doc: Python 3 compat, rst2man.py support, etc.
Date: Mon, 14 Apr 2014 21:00:15 +0300 [thread overview]
Message-ID: <m2ppkjpz9s.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <cover.1396718720.git.wking@tremily.us>
On Sat, Apr 05 2014, "W. Trevor King" <wking@tremily.us> wrote:
> I just bumped into this today while testing v2 of my
> content-description series:
>
> $ ./configure
> …
> $ make
> …
> python ./doc/mkdocdeps.py ./doc doc/_build doc/docdeps.mk
> Traceback (most recent call last):
> File "./doc/mkdocdeps.py", line 6, in <module>
> execfile(srcdir + '/conf.py')
> NameError: name 'execfile' is not defined
> …
>
> The first patch in this series fixes that issue, and the rest of the
> series fixes some other issues I bumped into while working on that.
> Sorry I missed these in the initial series.
>
> Note that while mkdocdeps.py and prerst2man.py are now Python 3
> compatible (with this series), the build will fail for Python's 3.0
> through 3.2 because of the explicit unicode literals in conf.py [1].
> It's likely that conf.py could use [2]
>
> from __future__ import unicode_literals
>
> drop the u'' prefixes, and be compatible with all Python's ≥2.6
> (including all 3s). I haven't checked the logic though, and I'm not
> running 3.2 locally anymore, so it's not a big priority for me.
>
> Cheers,
> Trevor
>
> [1]: https://docs.python.org/3/whatsnew/3.3.html#pep-414-explicit-unicode-literals
> [2]: from __future__ import unicode_literals
>
> W. Trevor King (7):
> doc/mkdocdeps.py: Convert execfile to import
> doc/mkdocdeps.py: Use "with" statement for the output file
> doc/prerst2man.py: Use Python-3-compatible octal notation
> doc/prerst2man.py: Fix 'os.system' -> 'system' typo
> doc: Allow rst2man.py as an alternative to rst2man
> doc/prerst2man.py: Convert execfile to import
> doc/INSTALL: Remove rst2man reference and other updates
In this series IMO the patches 1-4:
id:8d518408f2da8bc96ae3123f05791142da26b9bc.1396718720.git.wking@tremily.us
id:543aee63407956e60f85dc11a2d25855e98c10c3.1396718720.git.wking@tremily.us
id:5e4509ab08699afe2681110fb35075e1d0bbdc7e.1396718720.git.wking@tremily.us
id:c5ec510ac25c867ad600c475a0070a003440a4b8.1396718720.git.wking@tremily.us
could go in as those are. 5:
id:adce76bb9a0ca728d856da4ecaf6b282e22e7440.1396718720.git.wking@tremily.us
if, for consistency reason (we don't use absolute paths with other commands
either), rst2man/rst2man.py is used as is (and commit message adjusted
accordingly).
patch 6:
id:7c43c614cb09665400544fc0928ac14bb67ceeb5.1396718720.git.wking@tremily.us
would be good as is, but it doesn't apply without 5
In 7:
id:edf9a674bc1f41917caead8d38b5f09295a9d1bd.1396718720.git.wking@tremily.us
In addition to David's comments, s/genric/generic/ ;D. I don't have opinion
whether INSTALL should be changed to README.rst. Maybe this is good idea;
that also distingush between ./INSTALL & doc/INSTALL. In this case
`git grep INSTALL` shows that the line 83 in ./INSTALL needs to be changed,
too.
Tomi
PS: this id:<hash>.<timestamp>.git.<user@host> is PITA format to work with ;p
>
> configure | 12 +++++++-----
> doc/INSTALL | 34 ++++++++++++++++++++--------------
> doc/Makefile.local | 6 +++---
> doc/mkdocdeps.py | 19 ++++++++++---------
> doc/prerst2man.py | 25 ++++++++++++++-----------
> 5 files changed, 54 insertions(+), 42 deletions(-)
>
> --
> 1.9.1.353.gc66d89d
next prev parent reply other threads:[~2014-04-14 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 17:31 [PATCH 0/7] doc: Python 3 compat, rst2man.py support, etc W. Trevor King
2014-04-05 17:31 ` [PATCH 1/7] doc/mkdocdeps.py: Convert execfile to import W. Trevor King
2014-04-05 17:31 ` [PATCH 2/7] doc/mkdocdeps.py: Use "with" statement for the output file W. Trevor King
2014-04-05 17:31 ` [PATCH 3/7] doc/prerst2man.py: Use Python-3-compatible octal notation W. Trevor King
2014-04-05 17:31 ` [PATCH 4/7] doc/prerst2man.py: Fix 'os.system' -> 'system' typo W. Trevor King
2014-04-05 17:31 ` [PATCH 5/7] doc: Allow rst2man.py as an alternative to rst2man W. Trevor King
2014-04-05 19:05 ` Tomi Ollila
2014-04-05 19:19 ` W. Trevor King
2014-04-06 8:37 ` Tomi Ollila
2014-04-05 17:31 ` [PATCH 6/7] doc/prerst2man.py: Convert execfile to import W. Trevor King
2014-04-05 17:31 ` [PATCH 7/7] doc/INSTALL: Remove rst2man reference and other updates W. Trevor King
2014-04-05 20:35 ` David Bremner
2014-04-05 21:12 ` W. Trevor King
2014-04-05 22:53 ` David Bremner
2014-04-06 8:18 ` Tomi Ollila
2014-04-14 18:00 ` Tomi Ollila [this message]
2014-04-20 22:56 ` [PATCH 0/7] doc: Python 3 compat, rst2man.py support, etc David Bremner
2014-04-21 13:03 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ppkjpz9s.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).