From: Tomi Ollila <tomi.ollila@iki.fi>
To: Stefano Zacchiroli <zack@upsilon.cc>,
Jack Peirce <JPeirce@sourcecode.com>
Cc: "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Re: notmuch-mutt BSD compatibility
Date: Sat, 02 May 2015 11:37:02 +0300 [thread overview]
Message-ID: <m2pp6j74up.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20150501083623.GA6796@upsilon.cc>
On Fri, May 01 2015, Stefano Zacchiroli <zack@upsilon.cc> wrote:
> On Fri, May 01, 2015 at 05:24:39AM +0000, Jack Peirce wrote:
>> Some of the flags used in the notmuch-mutt script included in the
>> contrib directory are not supported by the OpenBSD implementation of
>> ln and xargs.
>
> I wasn't aware of that, so thanks for spotting it and for your patch.
>
> The patch looks good to me. I've also tested on my GNU/Linux machine and
> it works fine.
>
> David, please consider the attached (format-)patch for inclusion into
> the upcoming release of Notmuch.
This change LGTM.
Tomi
>
> Cheers.
> --
> Stefano Zacchiroli . . . . . . . zack@upsilon.cc . . . . o . . . o . o
> Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
> Former Debian Project Leader . . @zack on identi.ca . . o o o . . . o .
> « the first rule of tautology club is the first rule of tautology club »
> From 8641b7bc815d3a50a25069018faeb773b30499f2 Mon Sep 17 00:00:00 2001
> From: Jack Peirce <JPeirce@sourcecode.com>
> Date: Fri, 1 May 2015 10:32:05 +0200
> Subject: [PATCH] notmuch-mutt: fix xargs/ln usage for OpenBSD compatibility
>
> - xargs: use -r flag instead of --no-run-if-empty
> - ln: use -I flag/3rd form of ln command instead of -t flag/4th form
>
> Signed-off-by: Stefano Zacchiroli <zack@upsilon.cc>
> ---
> contrib/notmuch-mutt/notmuch-mutt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt
> index 126cbf4..b47b365 100755
> --- a/contrib/notmuch-mutt/notmuch-mutt
> +++ b/contrib/notmuch-mutt/notmuch-mutt
> @@ -50,7 +50,7 @@ sub search($$$) {
> empty_maildir($maildir);
> system("notmuch search --output=files $dup_option $query"
> . " | sed -e 's: :\\\\ :g'"
> - . " | xargs --no-run-if-empty ln -s -t $maildir/cur/");
> + . " | xargs -r -I searchoutput ln -s searchoutput $maildir/cur/");
> }
>
> sub prompt($$) {
> --
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2015-05-02 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 5:24 notmuch-mutt BSD compatibility Jack Peirce
2015-05-01 5:57 ` David Bremner
2015-05-01 8:36 ` Stefano Zacchiroli
2015-05-02 8:37 ` Tomi Ollila [this message]
2015-05-04 8:48 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pp6j74up.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=JPeirce@sourcecode.com \
--cc=notmuch@notmuchmail.org \
--cc=zack@upsilon.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).