From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 9E2256DE02AC
 for <notmuch@notmuchmail.org>; Mon, 14 Nov 2016 09:02:23 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.53
X-Spam-Level: 
X-Spam-Status: No, score=0.53 tagged_above=-999 required=5 tests=[AWL=-0.122, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id OZdlWcASs85e for <notmuch@notmuchmail.org>;
 Mon, 14 Nov 2016 09:02:22 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 8A4E36DE00D3
 for <notmuch@notmuchmail.org>; Mon, 14 Nov 2016 09:02:22 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id C94A51000CA;
 Mon, 14 Nov 2016 19:03:07 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Mark Walters <markwalters1009@gmail.com>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH] Test: fix draft test for emacs23
In-Reply-To: <87d1hym57r.fsf@tesseract.cs.unb.ca>
References: <1479131368-18545-1-git-send-email-markwalters1009@gmail.com>
 <87d1hym57r.fsf@tesseract.cs.unb.ca>
User-Agent: Notmuch/0.23.1+49~g8349b6a (https://notmuchmail.org) Emacs/24.5.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Mon, 14 Nov 2016 19:03:07 +0200
Message-ID: <m2polyt2no.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Nov 2016 17:02:23 -0000

On Mon, Nov 14 2016, David Bremner <david@tethera.net> wrote:

> Mark Walters <markwalters1009@gmail.com> writes:
>
>> emacs24 and emacs23 have different secure tag defaults: in particular,
>> mml-secure-message-sign only signs the part on emacs23 but the whole
>> message on emacs24. This difference makes one of the draft tests fail
>> (which causes a cascade of later failures) on emacs23. It seems that
>> travis uses emacs23 so it is useful to fix this.
>>
>> We do this by forcing the whole message to be signed in either case --
>> the code snippet is extracted from mml-secure-message-sign on emacs24.
>> ---
>
> Fixes the tests on emacs 23 for me, without the other other emacs23
> compatibility patch
>
> It's a little ugly, but it's the test suite. So I guess we go for it.

If you refer tabs converted to spaces then I agree on ugliness >;)

+1

>
> d