unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] Test: fix draft test for emacs23
@ 2016-11-14 13:49 Mark Walters
  2016-11-14 15:49 ` David Bremner
  2016-11-14 22:12 ` David Bremner
  0 siblings, 2 replies; 4+ messages in thread
From: Mark Walters @ 2016-11-14 13:49 UTC (permalink / raw)
  To: notmuch

emacs24 and emacs23 have different secure tag defaults: in particular,
mml-secure-message-sign only signs the part on emacs23 but the whole
message on emacs24. This difference makes one of the draft tests fail
(which causes a cascade of later failures) on emacs23. It seems that
travis uses emacs23 so it is useful to fix this.

We do this by forcing the whole message to be signed in either case --
the code snippet is extracted from mml-secure-message-sign on emacs24.
---

The main thing to note with this is that the motivation for fixing is
that travis seems to use emacs23.

Best wishes

Mark



test/T630-emacs-draft.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/T630-emacs-draft.sh b/test/T630-emacs-draft.sh
index 46fc356..cd9e33a 100755
--- a/test/T630-emacs-draft.sh
+++ b/test/T630-emacs-draft.sh
@@ -32,7 +32,9 @@ test_begin_subtest "Saving a signed draft adds header"
 test_emacs '(notmuch-mua-mail)
 	    (message-goto-subject)
 	    (insert "draft-test-0003")
-	    (mml-secure-message-sign)
+            ;; We would use (mml-secure-message-sign) but on emacs23
+            ;; that only signs the part, not the whole message.
+            (mml-secure-message mml-secure-method '\''sign)
 	    (notmuch-draft-save)
 	    (test-output)'
 header_count=$(notmuch show --format=raw subject:draft-test-0003 | grep -c ^X-Notmuch-Emacs-Secure)
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Test: fix draft test for emacs23
  2016-11-14 13:49 [PATCH] Test: fix draft test for emacs23 Mark Walters
@ 2016-11-14 15:49 ` David Bremner
  2016-11-14 17:03   ` Tomi Ollila
  2016-11-14 22:12 ` David Bremner
  1 sibling, 1 reply; 4+ messages in thread
From: David Bremner @ 2016-11-14 15:49 UTC (permalink / raw)
  To: Mark Walters, notmuch

Mark Walters <markwalters1009@gmail.com> writes:

> emacs24 and emacs23 have different secure tag defaults: in particular,
> mml-secure-message-sign only signs the part on emacs23 but the whole
> message on emacs24. This difference makes one of the draft tests fail
> (which causes a cascade of later failures) on emacs23. It seems that
> travis uses emacs23 so it is useful to fix this.
>
> We do this by forcing the whole message to be signed in either case --
> the code snippet is extracted from mml-secure-message-sign on emacs24.
> ---

Fixes the tests on emacs 23 for me, without the other other emacs23
compatibility patch

It's a little ugly, but it's the test suite. So I guess we go for it.

d

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Test: fix draft test for emacs23
  2016-11-14 15:49 ` David Bremner
@ 2016-11-14 17:03   ` Tomi Ollila
  0 siblings, 0 replies; 4+ messages in thread
From: Tomi Ollila @ 2016-11-14 17:03 UTC (permalink / raw)
  To: David Bremner, Mark Walters, notmuch

On Mon, Nov 14 2016, David Bremner <david@tethera.net> wrote:

> Mark Walters <markwalters1009@gmail.com> writes:
>
>> emacs24 and emacs23 have different secure tag defaults: in particular,
>> mml-secure-message-sign only signs the part on emacs23 but the whole
>> message on emacs24. This difference makes one of the draft tests fail
>> (which causes a cascade of later failures) on emacs23. It seems that
>> travis uses emacs23 so it is useful to fix this.
>>
>> We do this by forcing the whole message to be signed in either case --
>> the code snippet is extracted from mml-secure-message-sign on emacs24.
>> ---
>
> Fixes the tests on emacs 23 for me, without the other other emacs23
> compatibility patch
>
> It's a little ugly, but it's the test suite. So I guess we go for it.

If you refer tabs converted to spaces then I agree on ugliness >;)

+1

>
> d

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Test: fix draft test for emacs23
  2016-11-14 13:49 [PATCH] Test: fix draft test for emacs23 Mark Walters
  2016-11-14 15:49 ` David Bremner
@ 2016-11-14 22:12 ` David Bremner
  1 sibling, 0 replies; 4+ messages in thread
From: David Bremner @ 2016-11-14 22:12 UTC (permalink / raw)
  To: Mark Walters, notmuch

Mark Walters <markwalters1009@gmail.com> writes:

> emacs24 and emacs23 have different secure tag defaults: in particular,
> mml-secure-message-sign only signs the part on emacs23 but the whole
> message on emacs24. This difference makes one of the draft tests fail
> (which causes a cascade of later failures) on emacs23. It seems that
> travis uses emacs23 so it is useful to fix this.
>
> We do this by forcing the whole message to be signed in either case --
> the code snippet is extracted from mml-secure-message-sign on emacs24.
> ---

Pushed to master

d

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-14 22:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-14 13:49 [PATCH] Test: fix draft test for emacs23 Mark Walters
2016-11-14 15:49 ` David Bremner
2016-11-14 17:03   ` Tomi Ollila
2016-11-14 22:12 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).