From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 3/5] cli/dump: define GZPRINTF macro and use it in place of gzprintf
Date: Mon, 13 Apr 2020 11:52:25 +0300 [thread overview]
Message-ID: <m2pncbzs1i.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20200413021016.2799496-4-david@tethera.net>
On Sun, Apr 12 2020, David Bremner wrote:
> This will at least catch errors, and can be replaced with more
> sophisticated error handling where appropriate.
> ---
> notmuch-client.h | 3 +++
> notmuch-dump.c | 24 ++++++++++++------------
> 2 files changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/notmuch-client.h b/notmuch-client.h
> index 467e1d84..55d4d526 100644
> --- a/notmuch-client.h
> +++ b/notmuch-client.h
> @@ -497,6 +497,9 @@ print_status_gzbytes (const char *loc,
> gzFile file,
> int bytes);
>
> +#define ASSERT_GZBYTES(file, bytes) ( (print_status_gzbytes(__location__, file, bytes)) ? exit(1) : 0 )
__location__ ?? never seen such a (preprocessor?) definition. could not
find any reference by search...
there are also some suspiciously looking like inconsistent spaces in that
macro above
rest of the series (before and after) look good
Tomi
next prev parent reply other threads:[~2020-04-13 8:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 17:34 [PATCH] test: add known_broken test for dumping large stored queries David Bremner
2020-04-12 20:39 ` David Bremner
2020-04-13 2:10 ` David Bremner
2020-04-13 2:10 ` [PATCH 1/5] util/zlib-extra.c: don't pass NULL to gzerror David Bremner
2020-04-13 2:10 ` [PATCH 2/5] status: add print_status_gzbytes David Bremner
2020-04-13 2:10 ` [PATCH 3/5] cli/dump: define GZPRINTF macro and use it in place of gzprintf David Bremner
2020-04-13 8:52 ` Tomi Ollila [this message]
2020-04-13 11:21 ` David Bremner
2020-04-13 11:37 ` David Bremner
2020-04-13 2:10 ` [PATCH 4/5] cli/dump: define GZPUTS and use it in notmuch-dump David Bremner
2020-04-13 2:10 ` [PATCH 5/5] cli/dump: replace use of gzprintf with gzputs for config values David Bremner
2020-04-13 8:47 ` [PATCH] test: add known_broken test for dumping large stored queries Tomi Ollila
2020-04-13 9:43 ` Thomas Schneider
2020-04-13 12:36 ` [PATCH 1/6] " David Bremner
2020-04-13 12:36 ` [PATCH 2/6] util/zlib-extra.c: don't pass NULL to gzerror David Bremner
2020-04-13 12:36 ` [PATCH 3/6] status: add print_status_gzbytes David Bremner
2020-04-13 12:36 ` [PATCH 4/6] cli/dump: define GZPRINTF macro and use it in place of gzprintf David Bremner
2020-04-13 14:12 ` Tomi Ollila
2020-04-13 12:36 ` [PATCH 5/6] cli/dump: define GZPUTS and use it in notmuch-dump David Bremner
2020-04-13 12:36 ` [PATCH 6/6] cli/dump: replace use of gzprintf with gzputs for config values David Bremner
2020-04-13 23:03 ` [PATCH 1/6] test: add known_broken test for dumping large stored queries David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pncbzs1i.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).