From: David Edmondson <dme@dme.org>
To: =?utf-8?Q?T=E2=80=AEomi?= Ollila <tomi.ollila@iki.fi>,
"Teemu Likonen" <tlikonen@iki.fi>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v5] Emacs: Ensure left-to-right display for message headers
Date: Mon, 10 Aug 2020 09:43:13 +0100 [thread overview]
Message-ID: <m2pn7yao2m.fsf@dme.org> (raw)
In-Reply-To: <m28senfuj7.fsf@guru.guru-group.fi>
On Sunday, 2020-08-09 at 23:12:28 +03, =?utf-8?Q?T=E2=80=AEomi?= Ollila wrote:
> How about this =D
Your point being that the code sanitising the displayed header could do
better?
> (Sorry how the headers might look...)
>
> From: contains U+202E (LEFT-TO-RIGHT OVERRIDE) (in =?utf-8?Q?T=E2=80=AEomi?=)
>
> https://www.fileformat.info/info/unicode/char/202e/index.htm
>
> Tomi
>
> ---
>
> (top-posting on purpose, all rest is for reference only)
>
> On Fri, Aug 07 2020, Teemu Likonen wrote:
>
>> In notmuch-show buffer insert invisible U+200E LEFT-TO-RIGHT MARK
>> character at the beginning of message header paragraph if the From
>> header contains a right-to-left character. This ensures that the
>> header paragraph is always rendered in left-to-right mode.
>>
>> See Emacs Lisp reference manual section "(elisp) Bidirectional
>> Display" for more info.
>> ---
>> emacs/notmuch-show.el | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>>
>> As the commit description says this version inserts U+200E
>> LEFT-TO-RIGHT MARK only if the first header line (From header)
>> contains a right-to-left character.
>>
>> This version is probably friendlier to the current test files which
>> don't expect to see U+200E LEFT-TO-RIGHT MARK in the output.
>>
>>
>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
>> index c9170466..0eb27e33 100644
>> --- a/emacs/notmuch-show.el
>> +++ b/emacs/notmuch-show.el
>> @@ -466,10 +466,16 @@ unchanged ADDRESS if parsing fails."
>> (defun notmuch-show-insert-headerline (headers date tags depth)
>> "Insert a notmuch style headerline based on HEADERS for a
>> message at DEPTH in the current thread."
>> - (let ((start (point)))
>> + (let ((start (point))
>> + (from (notmuch-sanitize
>> + (notmuch-show-clean-address (plist-get headers :From)))))
>> + (when (string-match "\\cR" from)
>> + ;; If the From header has a right-to-left character add
>> + ;; invisible U+200E LEFT-TO-RIGHT MARK character which forces
>> + ;; the header paragraph as left-to-right text.
>> + (insert (propertize (string ?\x200e) 'invisible t)))
>> (insert (notmuch-show-spaces-n (* notmuch-show-indent-messages-width depth))
>> - (notmuch-sanitize
>> - (notmuch-show-clean-address (plist-get headers :From)))
>> + from
>> " ("
>> date
>> ") ("
>> --
>> 2.20.1
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
dme.
--
Our President's crazy, did you hear what he said?
next prev parent reply other threads:[~2020-08-10 8:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:13 Message headers in right-to-left mode in Emacs notmuch-show-mode Teemu Likonen
2020-08-03 7:37 ` Teemu Likonen
2020-08-04 12:16 ` [PATCH v2] Emacs: Force left-to-right display for message headers Teemu Likonen
2020-08-04 18:02 ` [PATCH v3] " Teemu Likonen
2020-08-05 8:45 ` David Edmondson
2020-08-05 9:40 ` Teemu Likonen
2020-08-05 9:50 ` Teemu Likonen
2020-08-05 10:03 ` David Edmondson
2020-08-05 10:32 ` [PATCH v4] " Teemu Likonen
2020-08-06 12:04 ` David Bremner
2020-08-06 14:50 ` Teemu Likonen
2020-08-06 14:59 ` Teemu Likonen
2020-08-07 4:46 ` [PATCH v5] Emacs: Ensure " Teemu Likonen
2020-08-07 9:23 ` David Edmondson
2020-08-08 19:21 ` David Bremner
2020-08-09 20:12 ` =?utf-8?Q?T=E2=80=AEomi?= Ollila
2020-08-10 8:43 ` David Edmondson [this message]
2020-08-10 16:45 ` Teemu Likonen
2020-08-10 18:27 ` Sanitize bidi control chars Teemu Likonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pn7yao2m.fsf@dme.org \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
--cc=tlikonen@iki.fi \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).