From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UAO6EHAXomBqSwEAgWs5BA (envelope-from ) for ; Mon, 17 May 2021 09:12:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uFFTDHAXomArFwAAB5/wlQ (envelope-from ) for ; Mon, 17 May 2021 07:12:48 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CA26219C93 for ; Mon, 17 May 2021 09:12:47 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 9A2AE29056; Mon, 17 May 2021 03:12:42 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 50A9B2903C for ; Mon, 17 May 2021 03:12:39 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 909F11B001B4; Mon, 17 May 2021 10:12:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1621235553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W5oelCTMt94ajz0TJ1tlkHiA8k6CgKP0lmRkHcCw2No=; b=YxkssDTOxOL/ymsqt/rvCnvafsJpQMGfUYdS35oPvhrRyQ0quwNLTBZXoZ/9xVSGDFW0bI UHit7ljqn4NDAdTOAeu5GkCqmyFF7nPqpmo28ld0PMDc1WgdZbNizvFMeONQMEaonrng6L HCjEXuxPLvWQVm/VvKYAUDXhPvt/eslDNULtAlSUuBoY5YY5ItpxVZdDpqSyTshsM1nH7J Y9Se8UgHnNqRS3qfhKPs31p54qj+AQEE45Sdq9Ptl07vV6BO2buaQa47xI5WbM+AHLIaYw CPKWTz7xIj9fc5e++3HE/xn63Vqub2N/DQOjZm4BF47DXAIAHSdLgQbqoXCsMw== From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Cc: David Bremner Subject: Re: [PATCH] test: add known broken test for duplicate thread-id terms In-Reply-To: <20210515130507.2629859-1-david@tethera.net> References: <20210515130507.2629859-1-david@tethera.net> User-Agent: Notmuch/0.32+21~gfdddd4c (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1621235553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W5oelCTMt94ajz0TJ1tlkHiA8k6CgKP0lmRkHcCw2No=; b=JzuKNfaMxMkZh1DfosCjDkYwbpBBZvLljBrqo1X54uoUyia1kJZ0wXq5ZpqeWxcqpXgCbt wx1J/vuOqZqQXmd6+Vtsr9EIamXRJ7z5IhqddLHjrppK6cXjhLbHE11eEhxvjuSHHjpykA Fvqdbic/fYrRfgP62D+9AEMnX9ekoMcmIMKKuTEN5HFcF7tV653qbgL6C8KiXCHJpTQ+SP HvF+2Q+h8hYkQ5qBrk2C5STmNbiKUWaMaDQrrWx06+vWCrEQRT61nTzG//VQhYrIMDPu1G GZh2MZ+DWTOAzdkYoHbyAUnlGTwG+Xkxoj9d3K2M4b/T3K86UNcVdyp3jJHosA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1621235553; a=rsa-sha256; cv=none; b=s4bpSmHNTWX/J4UoNH4Xsqa+ecmUlGQDQeXRJYAaXJl1vhJZUH6bNDAwcSAJNJQpVOT9Fl gAFPSCqo53dkytN5Ff8TPcJbuRUi8BBS5/926s1qT0MZiusTM61FX53a5ijt6b1yhcP/7e RjtI0zp55QK3CZxj777jA2Xj4tYUsbxbEUpqNWwu+mRnUXIUMXgZ43UmaJZo3JNr9RXxSm AO4xxubuHsKLTS09Vyjhth0ZNG04VPm2hobf1N7OI/jhuTzCOlpCh13S6/dG8TpY3PT81P CcpIvdzemFdpO2OmV3NhilWUm74c+iWfFItpfeVPfjsgkdlSgd2OcZViByctPQ== Message-ID-Hash: Y5H6EENE5AIYDKTJL7HSTFAO4EK4SZ2B X-Message-ID-Hash: Y5H6EENE5AIYDKTJL7HSTFAO4EK4SZ2B X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621235568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=wcX+02giO/sf4KA1ZJZ+sj//WwiRm4O0iBGSxYxJuHA=; b=J2koK/j4J3Ghsi8SROWA6b8sFd1bOtXwwOl7By6q0bWcGKSzycViFICFYr2MNbA4lPToTL wZkhYBwsK4W+0Yq9EKHiq3/TpGyvHtX0iXl5xZrCMsS7OCxjZYhyeGafCQjl1LPGxorbJz Onf0qN+lbqi3Rf7+mUQHENqp84A+6PEbcimVmJRDZq3hDXm3CU2c2m4hOQIrF/f7+D1hXF MrZABEQEDrNpmsiPyufZjovhggLMGH4l9BX8+hvXkLX0rVlHEWry2t3VdN4XT2TVTKOZDk M9KbaQ88sQjo49IOy/k+VKFI0LAhHzO8AYAlH+oD0+YH0FTTUM6X+aO72ZTKlA== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1621235568; a=rsa-sha256; cv=fail; b=iSTPCvIrn8gCq0CXx99Ofh9UGtY/V1wn19ZHO3Ul4jPVd55ReiZ7pTW5xP8NvNP4xYXtj5 TG9SEK40OEX43ZxOGFACACvLqKad/lT6PED3S4r5a023CO0UXZ11BoQCKHL4MDqAdWGr5t FAzT/MPZMxoKkq0nrTupupp5nQkv+CUbFgqTVgK0NxSUqkdg7HLYjTLw220LnUakJkUhIY F3BsUNelqBxaJl+cGqC8AQJujgjxr4NgpxfqrU8bjKXFISHSX8IIwZ7S05P0Xo25Jau6Sf 7ktiE+BXPBGW5gj2m+tn3RSXfeUX+KonyyolBr0SU8ZqcYAuD3imBQ64hNG4ZQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=YxkssDTO; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=YxkssDTO; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: CA26219C93 X-Spam-Score: 0.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: ooDRKM8tPqzP On Sat, May 15 2021, David Bremner wrote: > According to my bijection, this bug has been present since commit > 411675a6ce in 2017. It is apparently harmless for regular use, but > does make notmuch crash when compiled with -DDEBUG_DATABASE_SANITY. > --- > test/T670-duplicate-mid.sh | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/test/T670-duplicate-mid.sh b/test/T670-duplicate-mid.sh > index 4e5672ab..3fd59ca5 100755 > --- a/test/T670-duplicate-mid.sh > +++ b/test/T670-duplicate-mid.sh > @@ -2,10 +2,27 @@ > test_description="duplicate message ids" > . $(dirname "$0")/test-lib.sh || exit 1 > > +test_require_external_prereq xapian-delve > + > add_message '[id]="duplicate"' '[subject]="message 1" [filename]=copy1' > add_message '[id]="duplicate"' '[subject]="message 2" [filename]=copy2' > > add_message '[id]="duplicate"' '[subject]="message 0" [filename]=copy0' > + > +test_begin_subtest 'at most 1 thread-id per xapian document' > +test_subtest_known_broken > +db=${MAIL_DIR}/.notmuch/xapian > +cp /dev/null OUTPUT.raw > +for doc in $(xapian-delve -1 -t '' "$db" | grep '^[1-9]'); do > + xapian-delve -1 -r "$doc" "$db" | grep '^G' | wc -l >> OUTPUT.raw > +done for doc in $(xapian-delve -1 -t '' "$db" | grep '^[1-9]'); do xapian-delve -1 -r "$doc" "$db" | grep -c '^G' done > OUTPUT.raw will do (w/o cp /dev/null OUTPUT.raw) (also NOTE SPACING !!! >;D) > +sort -u < OUTPUT.raw > OUTPUT > +cat < EXPECTED > +0 > +1 > +EOF > +test_expect_equal_file EXPECTED OUTPUT > + > test_begin_subtest 'search: first indexed subject preserved' > cat < EXPECTED > thread:XXX 2001-01-05 [1/1(3)] Notmuch Test Suite; message 1 (inbox unread) > -- > 2.30.2