From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>,
Austin Clements <amdragon@MIT.EDU>,
notmuch@notmuchmail.org
Cc: sascha-ml-reply-to-2012-4@silbe.org
Subject: Re: [PATCH v2 0/3] Better id: link buttonization
Date: Wed, 14 Nov 2012 10:32:19 +0200 [thread overview]
Message-ID: <m2obj0ega4.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87k3to6h9p.fsf@betacantrips.com>
On Wed, Nov 14 2012, Ethan Glasser-Camp wrote:
> Austin Clements <amdragon@MIT.EDU> writes:
>
>> This is v2 of id:"1351650561-7331-1-git-send-email-amdragon@mit.edu".
>> This makes Jani's suggested additions to the regexp and adds support
>> for RFC 2392 mid: links, as suggested by Sascha.
>
> This series looks fine to me.
LGTM too.
although this is different than others in test/emacs:
+test_expect_equal_file EXPECTED OUTPUT
(grep test_expect_equal_file test/emacs)
The diff output in case of failure makes more sense when the args
are in this order -- but probably that should be changed
bu changing the arg handling order in test_expect_equal_file
(to be consistent with test_expect_equal) and then change the order
in the "remaining" uses of test_expect_equal_file EXPECTED OUTPUT.
> Ethan
Tomi
prev parent reply other threads:[~2012-11-14 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 4:46 [PATCH v2 0/3] Better id: link buttonization Austin Clements
2012-11-11 4:46 ` [PATCH v2 1/3] test: Test buttonization of id: links Austin Clements
2012-11-11 4:46 ` [PATCH v2 2/3] emacs: Improve the regexp used to match id:'s in messages Austin Clements
2012-11-11 4:46 ` [PATCH v2 3/3] emacs: Buttonize mid: links Austin Clements
2012-11-14 2:38 ` [PATCH v2 0/3] Better id: link buttonization Ethan Glasser-Camp
2012-11-14 8:32 ` Tomi Ollila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2obj0ega4.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=ethan.glasser.camp@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=sascha-ml-reply-to-2012-4@silbe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).