From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1784B431FAF for ; Sat, 14 Sep 2013 02:54:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2WFVm4CDnL7O for ; Sat, 14 Sep 2013 02:54:10 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 71E80431FAE for ; Sat, 14 Sep 2013 02:54:10 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 2426510007D; Sat, 14 Sep 2013 12:54:01 +0300 (EEST) From: Tomi Ollila To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 0/4] contrib: pick: allow more general format lines In-Reply-To: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com> References: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 09:54:18 -0000 On Mon, Sep 02 2013, Mark Walters wrote: > Currently pick makes the tree box graphics part of the "subject". This > is rather unsatisfactory: the tree graphics should be a field in their > own right. > > However, there is no mechanism in the current setup for allowing 2 > fields to have fixed combined width but variable individual > width. Thus making the tree graphics a seperate field means that we > cannot keep the current display which is > > date (12 characters) authors (20 characters) tree+subject (54 characters) tags > > We solve this by extending the format specifier. Previously this was a > list of cons cells (field-name . format-string) We now allow the > left-side (the field-name) itself to be a list of cons cells in which case we > apply the formatting recursively. > > This means we can separate the tree box graphics into their own field > while maintaining the current format. > > Note that this will mean that people who have customised the > result-format will need to update their customisation. > > The patch is larger but relatively simple. > > Patch 1/4 is unrelated except I found it while doing this update: we > consistency we should print () for messages with no tags. > > Patch 2/4 is large but trivial: it moves the insertion up a level in > preparation for the recursive formatting. > > Patch 3/4 is also simple: it just allows the recursive formatting. > > Patch 4/4 separates out the tree field. This patch is large as > it allows separate tree faces (matching and non-matching). The > "genuine code" part of the patch is relatively small. > > Finally, this is the last series (apart from some extra tests and > keeping up with mainline progress) that I think pick needs before it's > ready for consideration in non-contrib mainline. This series LGTM. One thing that I saw could be "improved" a bit: in notmuch-pick-format-field drop the formatted-field parameter and setq's to it. Something that can be done in follow-up patch if there is nothing else to be changed. I don't want to have any more review effort on this patchset due to that change :D +1 > > Best wishes > > Mark Tomi > > > > Mark Walters (4): > contrib: pick: print () for a message with no tags > contrib: pick: move the insertion of fields up a level > contrib: pick: allow recursive message field formats > contrib: pick: make the tree graphics a proper part of the format > > contrib/notmuch-pick/notmuch-pick.el | 93 ++++++++++++++++++++++++--------- > 1 files changed, 67 insertions(+), 26 deletions(-) > > -- > 1.7.9.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch