From: Tomi Ollila <tomi.ollila@iki.fi>
To: "W. Trevor King" <wking@tremily.us>, David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] doc: Allow rst2man.py as an alternative to rst2man
Date: Sat, 03 Jan 2015 19:12:13 +0200 [thread overview]
Message-ID: <m2oaqfbxg2.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20150103164506.GR14967@odin.tremily.us>
On Sat, Jan 03 2015, "W. Trevor King" <wking@tremily.us> wrote:
> On Sat, Jan 03, 2015 at 04:49:27PM +0100, David Bremner wrote:
>> At the risk of bike-shedding, rewrite the configure check to be more
>> "obvious". This is pretty subjective, but in particular I'm not a
>> big fan of resetting RST2MAN at the bottom of every iteration of the
>> for loop. Also conform a bit more to the convention of using a
>> lower case variable in configure and assigning it in Makefile.
>
> I'm fine with all of these changes.
I am also -- and I'd prefer lower-case variables -- however the convention
of using lower case variables is not so clear here (or weren't until
David's ${python} path ;) -- we have mixup of upper & lower case variables
there, and otoh, other (auto)configure scripts seems to use *_RST2MAN.
But, instead of working this further we could also consider Jani's irc comment
of dropping rs2man support altogether... or just keep the status quo and
instruct users just install (recent enough) sphinx to their systems to get
man pages created...
Tomi
PS: In one Scientific Linux 6.2 system I build and run notmuch I have
# Whether there's a sphinx-build binary available for building documentation
HAVE_SPHINX=0
# Whether there's a rst2man binary available for building documentation
HAVE_RST2MAN=1
because sphinx-build is not recent enough -- sphinx-1.0-build would be but
as it cannot be used by default and as rst2man (w/o .py) works I have not bothered.
I'd presume anyone else using such an old system will have bigger problems
getting their notmuch compiled (recent enough zlib being one of those), so
this makes me wonder whether there is actually anyone needing rst2man there
(besides me, of course :)
next prev parent reply other threads:[~2015-01-03 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 14:14 [PATCH] doc: Allow rst2man.py as an alternative to rst2man Tomi Ollila
2015-01-03 15:49 ` David Bremner
2015-01-03 16:45 ` W. Trevor King
2015-01-03 17:12 ` Tomi Ollila [this message]
2015-01-03 18:11 ` David Bremner
2015-01-03 18:35 ` W. Trevor King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2oaqfbxg2.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).