Re: Bug#755544: notmuch-emacs: doesn't check gpg/pgp signatures by default

[David Edmondson <dme@dme.org>]

On Tue, Jul 22 2014, David Bremner wrote:
> Jameson Graef Rollins <jrollins@finestructure.net> writes:
>
>> On Mon, Jul 21 2014, David Bremner <david@tethera.net> wrote:
>>> notmuch folks: it seems that in vagrant's message, and several others I
>>> checked, it notmuch-crypto-process-mime==nil, then no signature button
>>> is created at all.
>>
>> Yes, this is true.  The signature button is pretty meaningless if we're
>> not processing the signature.
>>
>> Maybe instead by default we could have a signature button that opens up
>> a notmuch-crypto-process-mime customization buffer?
>>
>> jamie.
>
> looking at the source, there is supposed to be some button:

There is a button for the part (the one that says "[multipart/signed]")
and the help text is associated with that. There is no button
specifically for the signature (because no processing of the signature
took place).

It wouldn't be complicated to add a button in the case where no checking
was done. Pressing the button could (as suggested) offer up
customisation of the variable (or just open the help).

I wonder if I could make the button be "[Danger Will Robinson!!!]" in
flashing red and yellow text...

> ,----
> | (defun notmuch-show-insert-part-multipart/signed (msg part content-type nth depth button)
> |   (button-put button 'face 'notmuch-crypto-part-header)
> |   ;; add signature status button if sigstatus provided
> |   (if (plist-member part :sigstatus)
> |       (let* ((from (notmuch-show-get-header :From msg))
> | 	     (sigstatus (car (plist-get part :sigstatus))))
> | 	(notmuch-crypto-insert-sigstatus-button sigstatus from))
> |     ;; if we're not adding sigstatus, tell the user how they can get it
> |     (button-put button 'help-echo "Set notmuch-crypto-process-mime to process cryptographic MIME parts."))
> `----