Re: [PATCH] test/emacs: revert invalid-from test to pre-86f89385 behaviour

[Tomi Ollila <tomi.ollila@iki.fi>]

On Sat, May 11 2019, David Bremner wrote:

> To the best of my understanding, this original behaviour was what
> Carl's homebrew parser produced. With commit 86f89385 Austin switched
> to using GMime (2.6). This produced arguably worse results, but since
> the input was bad, we could live with it. Now with GMime 3.0 we are
> getting the original results again, and there is no reason to consider
> this test broken.

if it works, push it !

> ---
>  test/T310-emacs.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
> index c06a8133..5f74305d 100755
> --- a/test/T310-emacs.sh
> +++ b/test/T310-emacs.sh
> @@ -86,14 +86,13 @@ test_emacs "(let ((notmuch-show-indent-messages-width 4))
>  test_expect_equal_file $EXPECTED/notmuch-show-thread-maildir-storage-with-fourfold-indentation OUTPUT
>  
>  test_begin_subtest "notmuch-show for message with invalid From"
> -test_subtest_known_broken
>  add_message "[subject]=\"message-with-invalid-from\"" \
>  	    "[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
>  thread=$(notmuch search --output=threads subject:message-with-invalid-from)
>  test_emacs "(notmuch-show \"$thread\")
>  	    (test-output \"OUTPUT.raw\")"
>  cat <<EOF >EXPECTED
> -"Invalid " (2001-01-05) (inbox)
> +Invalid " From <test_suite@notmuchmail.org> (2001-01-05) (inbox)
>  Subject: message-with-invalid-from
>  To: Notmuch Test Suite <test_suite@notmuchmail.org>
>  Date: GENERATED_DATE
> -- 
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch