From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 89ACB6DE0F5E
 for <notmuch@notmuchmail.org>; Thu, 13 Jun 2019 12:53:03 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.418
X-Spam-Level: 
X-Spam-Status: No, score=0.418 tagged_above=-999 required=5 tests=[AWL=-0.234, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id OANEGD-5cTGq for <notmuch@notmuchmail.org>;
 Thu, 13 Jun 2019 12:53:02 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id EE6486DE0F2C
 for <notmuch@notmuchmail.org>; Thu, 13 Jun 2019 12:53:01 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 21F56100084;
 Thu, 13 Jun 2019 22:52:56 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/8] cli: run uncrustify
In-Reply-To: <20190613110837.6256-5-david@tethera.net>
References: <20190613110837.6256-1-david@tethera.net>
 <20190613110837.6256-5-david@tethera.net>
User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 13 Jun 2019 22:52:55 +0300
Message-ID: <m2o931b6ug.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Jun 2019 19:53:03 -0000

On Thu, Jun 13 2019, David Bremner wrote:

> From: uncrustify <david@tethera.net>
>
> This is the result of running
>
>      $ uncrustify --replace --config devel/uncrustify.cfg *.c *.h
>
> in the top level source directory
> ---

Everything else than this one thing below and what I noticed looked like
what I've remembered uncrustify did (in 2014). IMO tolerable. We can see 
later if there is anything to improve -- it is easier when delta is small...

Series up to this poing pretty good...

Tomi

// ... stuff deleted ... //

> diff --git a/notmuch-config.c b/notmuch-config.c
> index b7f0784f..f16410a1 100644
> --- a/notmuch-config.c
> +++ b/notmuch-config.c
> @@ -300,20 +300,20 @@ out:
>   *
>   *	If is_new_ret is NULL, then a "file not found" message will be
>   *	printed to stderr and NULL will be returned.
> -
> + *
>   *	If is_new_ret is non-NULL then a default configuration will be
>   *	returned and *is_new_ret will be set to 1 on return so that
>   *	the caller can recognize this case.
>   *
> - * 	These default configuration settings are determined as
> - * 	follows:
> + *      These default configuration settings are determined as
> + *      follows:

The change above looks strange, why change tabs to spaces, if not elsewhere

>   *
>   *		database_path:		$MAILDIR, otherwise $HOME/mail
>   *
>   *		user_name:		$NAME variable if set, otherwise
>   *					read from /etc/passwd
>   *
> - *		user_primary_mail: 	$EMAIL variable if set, otherwise
> + *		user_primary_mail:      $EMAIL variable if set, otherwise

The above I',m not sure; '> +' disturbs experience too much ;/

... have to create worktree and apply series to see better...

>   *					constructed from the username and
>   *					hostname of the current machine.