From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uFrvEZ9e6F+BFwAA0tVLHw (envelope-from ) for ; Sun, 27 Dec 2020 10:14:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aNeoDZ9e6F/odwAA1q6Kng (envelope-from ) for ; Sun, 27 Dec 2020 10:14:55 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B64199404C4 for ; Sun, 27 Dec 2020 10:14:53 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id D7B3528C2E; Sun, 27 Dec 2020 05:14:43 -0500 (EST) Received: from lahtoruutu.iki.fi (unknown [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 1B8D128536 for ; Sun, 27 Dec 2020 05:14:41 -0500 (EST) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 66BCB1B0008C; Sun, 27 Dec 2020 12:14:28 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1609064068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wmffDfPvl/3ijgDoKl6U5bnqVk4izQrrdIowtK1cPQE=; b=IEHJs/mFHaoOFRdFLXwiERwt/fMY4Lh/+aFvjxw0fRO99rlT0LHgInhxBd6YXIZLpytj1N q5pTlAGKvXz/A6y4zTeoiEqPiZzDlYi9LpsVGh4etDC/GS8rckgttwRXL7ew0mNx7l8oDN 9tDq5HCsqu/+XBm2379TfYwnhr+UAzeQdy3vY7DGGycl22aSMwNpvPB1DGBtEwvuwz3cC/ oNCxCsiFpK9cdd9owYYW/ygCufXwlOZnwpTkjs849MLt65erlYtp9OBEMiC3z4isXHa4iJ TerXRiSmgWkf3Eifn6Zny+ptoVuhK2uSVqnMHqSahL87OgXjEPSducZJRTEJjg== From: Tomi Ollila To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH 00/32] [emacs] Add outline headings and switch to lexical scope In-Reply-To: <20201214162401.19569-1-jonas@bernoul.li> References: <20201214162401.19569-1-jonas@bernoul.li> User-Agent: Notmuch/0.31.2+29~gf517255 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1609064068; a=rsa-sha256; cv=none; b=GFzzTk31Q9XUEHaRCMfTok8CI22aBCPLiY1uPqpF6cOLwVIydRvYD1O+Mt1IMyEGq06h9N yjHoZF62EIfOWyVUbK4XUsgTs0WZr1094WkHZfNJdz+YzTL1qUTbRaiepV/H1hLm6qgX0D sAg+O4nSEOAzFGUXTLqLVFox/RH5O4lSu4lAsb/KVsPWZf1M3GxWcsA1ZTVdl1FK4pPVye xjD33jvCmqQKAD0t0FFFCDApDydM3D0ofdxa56Q47Q4ATzKhW/i4e/t5Llxb6dlykbGD2E 1lUo6rXBAwuvAq9dXAUZfRv7LRfrdpXPKLAmFd3VAzc9TPQzUTDKL2wa+7S03g== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1609064068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wmffDfPvl/3ijgDoKl6U5bnqVk4izQrrdIowtK1cPQE=; b=LHiZk1mZDdCsuds6H4BCva3tmenVR4mAkVpEBV+ogVyYJwwdm2r8/nlv6AMU1gD7LUqY3s Zl0KmzMyhlmjfx3XZi6NExwJRm/HSxfwwpjnOhAnynsGwlUx+R14KMy0uEgwUsqeY+DxLd vZwtmQi3gHZePt5nG/X/5yVgDks7DPjtS2bu1TpvyKYl27AERX2rYo8TY9yhRU3Bg4c/XY cs21l1we5pyZVtVa99Qa6GQWRi2YeCovmYf4i9deJhQkgifn1oioy/51B84Ux/7c07S4PT xC1f3byOZ6ebw1u/NmcXKhF78VSgsPxqpubE1E709z7HbbD4cIkDtxoySZI5PA== Message-ID-Hash: APXFEXKN7XBKLX6M7RKU4N4VIUY55TNR X-Message-ID-Hash: APXFEXKN7XBKLX6M7RKU4N4VIUY55TNR X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.59 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=IEHJs/mF; arc=reject (signature check failed: fail, {[1] = sig:iki.fi:reject}); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B64199404C4 X-Spam-Score: 2.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: cGMo0/EUyfGp On Mon, Dec 14 2020, Jonas Bernoulli wrote: > Hello, > > This patch serious changes a number of things, including boring > cleanup, but the big changes are the following. The respective > commits are also marked in the list below. See these commits > for longer descriptions. > > 1. Split all libraries into sections by adding new headings or > formatting existing headings properly to be compatible with > outline-minor-mode. > > 2. Use lexical-scope in all libraries. This is potentially faster > and is recommended for all new code (and old code someone cares > about enough). It also has the advantage that it can reveal > subtle bugs. The patch series did not apply for me (fully) anymore. First had to be skipped, then two of more of the last, therefore I did not put this into use for now (as, if it fails I don't know whether the reason is dropped changes or my way of building it...) I like the series (on paper), 2 comments In patch 23/32, line + (y-or-n-p (format "Fcc header %s is an absolute path%s%s" subdir should be + (y-or-n-p (format "Fcc header %s is an absolute path %s %s" subdir (I.e. spaces around %s's) Then, I personally don't see enough point for requiring subr-x just just for changing (string= foo "") to (string-empty-p). If there were more features picked from subr-x then that would be different... > Among the many more commits that do not concern these two big > changes, there are a few that might need special attention. > (Again see the commits for details.) > > 3. No longer use Ido in notmuch-mua-prompt-for-sender. Might be > controversial. > > 4. Stop using unnecessary let-bindings, though how "unnecessary" > these bindings are is somewhat subjective. I like these two changes. > > Cheers, > Jonas Tomi PS: I used the following code to drop cr's (\r) from base64-encoded text blobs; just enough to work in this particular case. #!/usr/bin/perl # -*- mode: cperl; cperl-indent-level: 4 -*- use 5.8.1; use strict; use warnings; use MIME::Base64; while () { print $_; if (/^Content-Transfer-Encoding: base64/) { while () { print $_; last if /^\s*$/ } my @lines; while () { last if /^\s*$/; push @lines, $_ } my $decoded = decode_base64 join('', @lines); $decoded =~ tr/\r//d; print(encode_base64 $decoded); print "\n" } }