From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gJjeF2PufmGXdQEAgWs5BA (envelope-from ) for ; Sun, 31 Oct 2021 20:28:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2GSbE2PufmGvaAAA1q6Kng (envelope-from ) for ; Sun, 31 Oct 2021 19:28:35 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 206462D6BE for ; Sun, 31 Oct 2021 20:28:35 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E979F1FD53; Sun, 31 Oct 2021 15:28:28 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 207191FD37 for ; Sun, 31 Oct 2021 15:28:25 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id F11BF1B0007F; Sun, 31 Oct 2021 21:28:20 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1635708501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rDxTQr+UtQcQROWRwTQa7CPDJ+jvQk+xzcNlL+kw8uU=; b=jgVxdpni9NObBBvLRXVh/6X12pUz6bHfoz9sH0q89dB77PVOrxyMTdlY9f4pENzGmyZKtR W96cDt8YLQE99BVUgVVRvZH7yqbAw2i9bOqsQCuNpMgraAYHREdw/aCVj1K7m2jCLu1xZq zLxCdyZbvdDtdlK3/77fD+rtSbFX9OQArii62mnSYju5Je4/mzxm3G0nTmd/TbmOL3vRWA YTx8rb99pXcNTUvTWRbgxnVB/ARYpIm37iXvgYe4704IwiKFVeplQ3XscIXBLUHLsloi1p Y9hjly4snRxRJdJtMwlzX1h5sB2rVrZiFo8TF4CKXxL9phESH+53m8TREdDq8w== From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [RFC PATCH] python-cffi out-of-tree build In-Reply-To: <8735oh8lsj.fsf@tethera.net> References: <20210217213600.10268-1-tomi.ollila@iki.fi> <8735oh8lsj.fsf@tethera.net> User-Agent: Notmuch/0.33+54~gcaf4513 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1635708501; a=rsa-sha256; cv=none; b=p2TZYZRUCXt/LtpHJewgk/hYUh7q2694KWyV3xNjzH+F0CWj9CBM++FSvvNUUJGlAA4TPk g6r0GQ/HwRrWW4h8cWIDDtrGsJsY5Edq8D+sVvnpwTTjcqj5Nf+qhtPk+KBofveHNtkchs hr7ixD1af3YxlAU+nNQVwYIlQOonLzgFhfpRF0M6zAVlBcJYWQeQlUlpWpddw8peP7uc4N GRkNSXV+iYRkRfvrXhQjfKKjwiMWoiafgVH3hdxOpSuWckkX+OdE6CqbRvN71Q97XrKXeo izymmZa99a3w6d4UHQvbvlNKMyAU3uHjPujj7V+Hy35gNknwMvZ0jXb/JZkEKw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1635708501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rDxTQr+UtQcQROWRwTQa7CPDJ+jvQk+xzcNlL+kw8uU=; b=AK6wCfvDyzbJ2yWx3WhpxcnOM+oGISfP/ag5BpH4qZsnyAj6DjBRf1hwfM7qLAdzZFV791 qFvF/jskBFHf9/ikp/nWJHy5S7SS42jzViPOt2FgNWulwNjXJ3OnnnCSY7ITICiNzTEGx/ 5fIKTGv1+tr6a1mr0Jlye0WvGBtXAuHtBtfePpDLs9OD0Acgh1FfDcHj44cNR6rs5+lNME JDvlTrWTfu8yQUNiQJoxbUePv7crgCPT5mCLTE00pY3uqUkSFrCDBhLKKenhYjRsEFNnyp SucSy595FmpPo2yA+RH4ZIUwgYRIh0mZebjtAwQkt28316rtqkbY+wFHD2BNYA== Message-ID-Hash: VUUKLNGYAR4WOAFZCMA3X47MUS2LDO2L X-Message-ID-Hash: VUUKLNGYAR4WOAFZCMA3X47MUS2LDO2L X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635708515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=eyfoUgKbYaO/3RSEgxvsPcEus96FzbydlZN07VfhdLY=; b=W+RgZIASyi3TeTeJmXHHG8KtpkAcORm8rUsSXAABtjwyWM+M3EeiFVT1nXWA+9oK6qm/Hf JVajFbTsn7RgS6BCQ6F2AS1Kxooa5epo4igrkMBD3dhxQ0C9WBK/7n0NQrbm9Ddnljx+Qp Q3+utx2sgYOHxvy3Kg02Cvqj7jAF4X2q9ctNzO5xIl5LyJiBDrK6DEIMTOYOd1fDNvpJM9 w0aAxLTefs44WobA6e1mSoj7+33dT4LSJfFUXmaL277rMHDdwkIhItSv0qyM36r5KRo4wX ef2hNYO77da5Sl1AMkX+pfWWaUV9LjUMW3QxfKEk4hiBrA4hJR6diz1xTUMe9A== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1635708515; a=rsa-sha256; cv=fail; b=MF/l4ZtCFB8GfVfYcIInzIg6P+Jjs/1ZMzcvRsUVKe23ZyDdTWJgrIic8HXZG9cQnN8ABg Bsb4OUrVsh8VZpHlBh4G4jFVwMnAJTYeAAN8Wt5LsH32JKkCYR4lKw9brGTlSplNXFrNo2 K40S7QYmMjtHn0a92flci2/Szqs42vMKQItdnAbQLtjxZEb9tM9oVbqowklPLm8rdVJGkJ uUZ2T/ALQYhMqIgubxMerAybvfkCSTnXgBLCwCW492bFb4ZfL8x3oCqCk+RTwP0XtkFgWw CnLvadb18xYrFttivylbuY/IcPL0RI/r+0gJz/qP5op8XOxblQgJw3sb7fMwdQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=jgVxdpni; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=jgVxdpni; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 206462D6BE X-Spam-Score: 0.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1J8GZQHcaTmp On Sun, Oct 31 2021, David Bremner wrote: > Tomi Ollila writes: > >> setup.py and _build.py to refer some other files based on directory >> where setup.py is located (os.path.dirname(sys.argv[0]). >> >> Dropped bindings/python-cffi/version.txt and refer ../../version.txt >> instead -- _build.py already refers ../../lib so why have version.txt >> twice (with identical content). >> >> Dropped copying of bindings/python-cffi source files to the build >> directory bindings/python-cffi in configure. > > Apologies, I think I did not read this discussion very carefully > before. I guess [1] is an alternative to the first two points. I'm not > sure which approach is better. Mine is a bigger hammer, but maybe that > could be useful in the future? > > The patch at [1] does not (by itself) allow the third change, but > probably some similar hacking of setup.py, but using the newly created > _notmuch_config.py would work. > > Tomi, did you happen to test "pip install ." with your approach? I'm > afraid your patch doesn't (easily) apply anymore so I was too lazy to > test myself. IIRC my approaches had quite a few problems which I thought soon after emailing so probablhy your versions are better. Have to look... Tomi > > Cheers, > > db > > [1]: id:20211031100354.1697379-1-david@tethera.net > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org