From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style
Date: Sat, 21 Jan 2012 23:35:27 +0200 [thread overview]
Message-ID: <m2mx9gwxgg.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87sjj8bvvn.fsf@zancas.localnet>
On Sat, 21 Jan 2012 17:15:08 -0400, David Bremner <david@tethera.net> wrote:
> On Tue, 10 Jan 2012 08:07:07 -0400, David Bremner <david@tethera.net> wrote:
> > From: David Bremner <bremner@debian.org>
> >
> > Uncrustify is a free (as in GPL2+) tool that indents and beautifies
> > C/C++ code.
>
> I pushed a revised version of this, with some input from Tomi. I guess
> this should be documented somewhere either the wiki, under devel, or
> both. Perhaps we should work on a "coding style" page on the wiki, and
> then copy snapshots of that into ./devel? Or just edit a text file in
> ./devel?
It would be best to have the documents in ./devel and just references to
those on the wiki. To avoid duplication and content drifting.
That particular case:
enum format_enum { NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT }
- format_sel = NOTMUCH_FORMAT_TEXT;
+ format_sel = NOTMUCH_FORMAT_TEXT;
Is interesting, running emacs -q notmuch-search.c and tab-indenting that
same line yieds the same results. However, on top-level, i.e.:
enum format_enum { NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT }
format_sel = NOTMUCH_FORMAT_TEXT;
emacs indents just like above.
I like this suggestion:
>*> enum format_enum {
>*> NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT
>*> } format_sel = NOTMUCH_FORMAT_TEXT;
>
> d
>
Tomi
next prev parent reply other threads:[~2012-01-21 21:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 15:28 [PATCH] uncrustify.cfg: initial support for notmuch coding style David Bremner
2011-12-17 22:50 ` David Bremner
2011-12-17 23:57 ` Austin Clements
2011-12-18 1:37 ` David Bremner
2012-01-10 12:07 ` David Bremner
2012-01-10 12:07 ` [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style David Bremner
2012-01-12 4:00 ` Austin Clements
2012-01-17 15:36 ` Tomi Ollila
2012-01-21 21:15 ` David Bremner
2012-01-21 21:35 ` Tomi Ollila [this message]
2012-01-10 12:07 ` [PATCH 2/2] notmuch-reply.c: uncrustify David Bremner
2012-01-11 15:22 ` Tomi Ollila
2012-01-12 3:57 ` Austin Clements
2012-01-12 13:08 ` David Bremner
2012-01-12 13:22 ` Jani Nikula
2012-01-12 13:46 ` Tomi Ollila
2012-01-12 15:26 ` Austin Clements
2012-01-21 19:00 ` David Bremner
2012-01-11 16:03 ` where to put uncrustify... (was: Re: ) Tomi Ollila
2012-01-12 0:15 ` David Bremner
2012-01-17 12:47 ` [PATCH] Start devel directory for developer tools and documentation David Bremner
2012-01-17 23:23 ` Austin Clements
2012-01-18 2:54 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mx9gwxgg.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).